Skip to content

[Wasm RyuJIT] Partially implement genStructReturn #126326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kg merged 4 commits into from
Mar 31, 2026
Merged

[Wasm RyuJIT] Partially implement genStructReturn #126326

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f408c06
Support struct returns where the operand is a single-element fieldlis…
kg Mar 30, 2026
c36227b
Address copilot feedback
kg Mar 30, 2026
04e0d6c
Add missing change
kg Mar 30, 2026
9ba57f0
Don't emit a return
kg Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/coreclr/jit/codegenwasm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3098,7 +3098,34 @@ void CodeGen::genEHCatchRet(BasicBlock* block)

void CodeGen::genStructReturn(GenTree* treeNode)
{
NYI_WASM("genStructReturn");
assert(treeNode->OperIs(GT_RETURN));

GenTree* op1 = treeNode->AsOp()->GetReturnValue();
GenTree* actualOp1 = op1->gtSkipReloadOrCopy();

const ReturnTypeDesc& retTypeDesc = m_compiler->compRetTypeDesc;
const unsigned regCount = retTypeDesc.GetReturnRegCount();

assert(regCount <= MAX_RET_REG_COUNT);

Comment thread
kg marked this conversation as resolved.
if (actualOp1->OperIsFieldList())
{
// Go through and consume the fields in the field list so liveness is correct.
unsigned regIndex = 0;
for (GenTreeFieldList::Use& use : actualOp1->AsFieldList()->Uses())
{
genConsumeReg(use.GetNode());
regIndex++;
}

// We should only have one field in the field list, and MAX_RET_REG_COUNT is 1 on Wasm.
assert(regIndex == regCount);
assert(regIndex == 1);

return;
}

NYI_WASM("genStructReturn non-fieldlist cases");
}

void CodeGen::genEmitGSCookieCheck(bool tailCall)
Expand Down
Loading