Skip to content

Fix SkipOnCoreClr generating unreachable test code in standalone runner #126517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 4 commits into from
Apr 8, 2026
+11 −6
Merged

Fix SkipOnCoreClr generating unreachable test code in standalone runner #126517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b33766
Fix SkipOnCoreClr generating unreachable test code in standalone runner
MichalStrehovsky Apr 3, 2026
498b772
Add ActiveIssue attribute to Validate_Managed_IMallocSpy test
MichalStrehovsky Apr 6, 2026
d0ac78c
Add ActiveIssueAttribute for multithreading support
MichalStrehovsky Apr 6, 2026
b5d1a09
Merge branch 'main' into skiponcoreclr
MichalStrehovsky Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/tests/Common/XUnitWrapperGenerator/XUnitWrapperGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,9 +843,9 @@ private static IEnumerable<ITestInfo> GetTestMethodInfosForMethod(IMethodSymbol
continue;
}

Xunit.TestPlatforms skippedTestPlatforms = Xunit.TestPlatforms.Any;
Xunit.RuntimeConfiguration skippedConfigurations = Xunit.RuntimeConfiguration.Any;
Xunit.RuntimeTestModes skippedTestModes = Xunit.RuntimeTestModes.Any;
Xunit.TestPlatforms skippedTestPlatforms = 0;
Xunit.RuntimeConfiguration skippedConfigurations = 0;
Xunit.RuntimeTestModes skippedTestModes = 0;

for (int i = 1; i < filterAttribute.ConstructorArguments.Length; i++)
{
Expand All @@ -871,9 +871,9 @@ void ReadSkippedInformationFromSkipOnCoreClrAttributeArgument(TypedConstant argu
}
}

if (skippedTestModes == Xunit.RuntimeTestModes.Any
&& skippedConfigurations == Xunit.RuntimeConfiguration.Any
&& skippedTestPlatforms == Xunit.TestPlatforms.Any)
if (skippedTestModes == 0
&& skippedConfigurations == 0
&& skippedTestPlatforms == 0)
{
testInfos = FilterForSkippedRuntime(testInfos, (int)Xunit.TestRuntimes.CoreCLR, options);
}
Expand Down
1 change: 1 addition & 0 deletions src/tests/Interop/COM/ExtensionPoints/ExtensionPoints.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ public virtual void PostHeapMinimize() { }

[Fact]
[Xunit.SkipOnCoreClrAttribute("Depends on marshalled calli", RuntimeTestModes.InterpreterActive)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/126567")]
public static unsafe void Validate_Managed_IMallocSpy()
{
Console.WriteLine($"Running {nameof(Validate_Managed_IMallocSpy)}...");
Expand Down
4 changes: 4 additions & 0 deletions src/tests/JIT/Methodical/tailcall_v4/hijacking.il
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,10 @@
string('needs triage')
int32(0x11E) // AnyJitOptimizationStress
}
.custom instance void [Microsoft.DotNet.XUnitExtensions]Xunit.ActiveIssueAttribute::.ctor(string, valuetype [Microsoft.DotNet.XUnitExtensions]Xunit.TestPlatforms) = {
string('System.Threading.Thread.ThrowIfMultithreadingIsNotSupported: PlatformNotSupportedException')
int32(0x400) // TestPlatforms.Browser
}
.entrypoint
// Code size 300 (0x12c)
.maxstack 5
Expand Down
Loading