Use ThrowHelper in JsonElement.GetByte/GetSByte/GetInt16/GetUInt16#126559
Merged
danmoseley merged 4 commits intodotnet:mainfrom Apr 20, 2026
Merged
Use ThrowHelper in JsonElement.GetByte/GetSByte/GetInt16/GetUInt16#126559danmoseley merged 4 commits intodotnet:mainfrom
danmoseley merged 4 commits intodotnet:mainfrom
Conversation
Replace inline `throw new FormatException()` statements in JsonElement.GetSByte, GetByte, GetInt16, and GetUInt16 with ThrowHelper.ThrowFormatException calls, consistent with the pattern established in dotnet#61746.
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns JsonElement.GetSByte, GetByte, GetInt16, and GetUInt16 with the existing System.Text.Json throw-helper pattern by replacing inline throw new FormatException() statements with ThrowHelper.ThrowFormatException() calls, consistent with prior refactors (e.g., #61746).
Changes:
- Refactors
GetSByte()to throw viaThrowHelper.ThrowFormatException()whenTryGetSByte()fails. - Refactors
GetByte(),GetInt16(), andGetUInt16()similarly to centralizeFormatExceptionthrowing.
EgorBo
approved these changes
Apr 5, 2026
rosebyte
approved these changes
Apr 8, 2026
This was referenced Apr 19, 2026
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replace inline
throw new FormatException()statements inJsonElement.GetSByte,GetByte,GetInt16, andGetUInt16withThrowHelper.ThrowFormatExceptioncalls, consistent with the pattern established in #61746.