Skip to content

[Apple mobile] Skip unsupported tests on Apple mobile platforms #126631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotlarmilos merged 11 commits into from
Apr 10, 2026
Merged

[Apple mobile] Skip unsupported tests on Apple mobile platforms #126631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fe76a4a
Fix test failures on iOS, tvOS, and MacCatalyst
kotlarmilos Apr 8, 2026
06faffb
Fix runtime tests
kotlarmilos Apr 8, 2026
3f6dcd4
Update src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs
kotlarmilos Apr 8, 2026
eb96443
Skip UserNameCantBeCombinedWithInheritedHandles on Apple mobile
kotlarmilos Apr 8, 2026
8bd3e7b
Gate GetMethodImplementationFlags tests on IsNotMonoRuntime instead o…
kotlarmilos Apr 8, 2026
d8f9cdd
[Apple mobile] Disable TraceSource config tests under aggressive trim…
vitek-karas Apr 8, 2026
0a44f50
Merge branch 'main' into fix/apple-mobile-test-failures
kotlarmilos Apr 8, 2026
9443cea
Update src/tests/build.proj
kotlarmilos Apr 9, 2026
8b9ccc3
Merge branch 'main' into fix/apple-mobile-test-failures
kotlarmilos Apr 9, 2026
38e4171
Merge branch 'main' into fix/apple-mobile-test-failures
kotlarmilos Apr 9, 2026
0ad7258
Skip TraceSource config tests on Apple mobile CoreCLR via tests.proj
kotlarmilos Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ private static bool GetLinqExpressionsBuiltWithIsInterpretingOnly()

public static bool IsAssemblyLoadingSupported => !IsNativeAot;
public static bool IsNonBundledAssemblyLoadingSupported => IsAssemblyLoadingSupported && !IsMonoAOT;
public static bool IsMethodBodySupported => !IsNativeAot;
public static bool IsMethodBodySupported => !IsBuiltWithAggressiveTrimming;
public static bool IsDebuggerTypeProxyAttributeSupported => !IsNativeAot;
Comment thread
kotlarmilos marked this conversation as resolved.
public static bool HasAssemblyFiles => !string.IsNullOrEmpty(typeof(PlatformDetection).Assembly.Location);
Comment thread
kotlarmilos marked this conversation as resolved.
public static bool HasHostExecutable => HasAssemblyFiles; // single-file don't have a host
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,7 @@ public void StartInfo_LoadUserProfile_And_UseCredentialsForNetworkingOnly_AreInc
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "Process.Start is not supported on iOS, tvOS, and MacCatalyst.")]
public void UserNameCantBeCombinedWithInheritedHandles()
{
using Process longRunning = CreateProcessLong();
Comment thread
kotlarmilos marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Reflection.Context/tests/CustomConstructorInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public void GetMethodBody_ReturnsBody()
Assert.NotNull(body);
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customConstructor.GetMethodImplementationFlags();
Comment thread
kotlarmilos marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Reflection.Context/tests/CustomMethodInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public void GetMethodBody_ReturnsBodyWithLocals()
Assert.NotNull(body.LocalVariables);
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotMonoRuntime))]
public void GetMethodImplementationFlags_ReturnsIL()
{
MethodImplAttributes flags = _customMethod.GetMethodImplementationFlags();
Comment thread
kotlarmilos marked this conversation as resolved.
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,9 @@
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Collections.Concurrent\tests\System.Collections.Concurrent.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Net.HttpListener\tests\System.Net.HttpListener.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.Json\tests\System.Text.Json.Tests\System.Text.Json.Tests.csproj" />

<!-- Not supported on Apple mobile -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Diagnostics.TraceSource\tests\System.Diagnostics.TraceSource.Config.Tests\System.Diagnostics.TraceSource.Config.Tests.csproj" />
</ItemGroup>

<!-- https://github.com/dotnet/runtime/issues/124044 -->
Expand Down
1 change: 1 addition & 0 deletions src/tests/build.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@
<PropertyGroup>
<_RestoreProperties>MSBuildRestoreSessionId=$([System.Guid]::NewGuid());TargetOS=$(TargetOS);TargetArchitecture=$(TargetArchitecture);Configuration=$(Configuration);CrossBuild=$(CrossBuild);SetTFMForRestore=true;RuntimeIdentifier=$(RuntimeIdentifier)</_RestoreProperties>
<_RestoreProperties Condition="'$(UseLocalAppHostPack)' == 'true' or '$(TargetOS)' == 'browser'">$(_RestoreProperties);EnableAppHostPackDownload=false;EnableTargetingPackDownload=false;EnableRuntimePackDownload=false</_RestoreProperties>
Comment thread
kotlarmilos marked this conversation as resolved.
<_RestoreProperties Condition="'$(TargetsAppleMobile)' == 'true'">$(_RestoreProperties);RestoreUseStaticGraphEvaluation=false</_RestoreProperties>
</PropertyGroup>
Comment thread
kotlarmilos marked this conversation as resolved.

<!-- Use a dedicated traversal project to restore all test dependencies in one graph invocation. -->
Expand Down
Loading