[wasm][coreclr] Enable webcil V1 for CoreCLR wasm builds#126876
Merged
radekdoulik merged 1 commit intodotnet:mainfrom Apr 14, 2026
Merged
[wasm][coreclr] Enable webcil V1 for CoreCLR wasm builds#126876radekdoulik merged 1 commit intodotnet:mainfrom
radekdoulik merged 1 commit intodotnet:mainfrom
Conversation
Add WebcilVersion property to ConvertDllsToWebcil MSBuild task and plumb it through to the WebcilConverter. The SDK targets default to V1 when RuntimeFlavor is CoreCLR, V0 otherwise. Users can override via the WasmWebcilVersion property. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
radekdoulik
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
radekdoulik
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Enables Webcil V1 output by default for CoreCLR WebAssembly builds by plumbing a Webcil version setting from MSBuild into the Webcil conversion task.
Changes:
- Added a
WebcilVersionparameter to theConvertDllsToWebcilMSBuild task and forwarded it toWebcilConverter. - Introduced
_WasmWebcilVersionMSBuild property logic to default to V1 forRuntimeFlavor=CoreCLRand V0 otherwise. - Passed the resolved Webcil version into conversion during both build and publish pipelines.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ConvertDllsToWebCil.cs | Adds MSBuild task parameter and forwards it to the Webcil conversion API. |
| src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets | Computes default Webcil version per runtime flavor and supplies it to conversion tasks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
PR description co-authored with Copilot.
Building on #126709 which added V1 webcil support infrastructure, this enables V1 webcil output for CoreCLR wasm builds.
It addresses remaining feedback from #126709
Changes
WebcilVersionproperty to the MSBuild task, plumb it to theWebcilConverter_WasmWebcilVersionproperty defaults to V1 whenRuntimeFlavor=CoreCLR, V0 otherwise. Users can override viaWasmWebcilVersion.cascade