Improve xplat dump test work item naming#126906
Merged
max-charlamb merged 3 commits intodotnet:mainfrom Apr 17, 2026
Merged
Conversation
Include both the host platform and dump source in Helix work item names so AzDO test results clearly show which host analyzed which dumps (e.g. CdacXPlatDumpTests_host_linux_arm_dumps_windows_x64). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
max-charlamb
force-pushed
the
fix/xplat-dump-test-naming
branch
from
66d1d6a to
46bea46
Compare
max-charlamb
force-pushed
the
fix/xplat-dump-test-naming
branch
2 times, most recently
from
36e3d09 to
67e11cf
Compare
steveisok
approved these changes
Apr 16, 2026
When running xplat dump tests, include the dump source platform in TestConfiguration.ToString() so individual test results in AzDO show which platform's dumps were being analyzed (e.g. 'local/r2r (windows_x64)'). The dump source is extracted from the CDAC_DUMP_ROOT environment variable which is set by the Helix work item. For local runs, DumpSource is null and the display is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
max-charlamb
force-pushed
the
fix/xplat-dump-test-naming
branch
from
86bb9a6 to
9934683
Compare
- Use underscore separator (windows_x64) consistently across Helix work item names, dump-info.json output, and test display names - Format test display as parenthesized suffix: local/r2r (windows_x64) - Pass typeof(string) to AddValue for nullable DumpSource serialization - Document TargetArchitecture in helix proj properties Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hoyosjs
reviewed
Apr 17, 2026
hoyosjs
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR description was generated with the help of Copilot.
Summary
Improve xplat cDAC dump test naming so that both the host platform and dump source platform are visible in test results.
Helix work item names
Before:
CdacXPlatDumpTests_windows_x64After:
CdacXPlatDumpTests_host_linux_arm_dumps_windows_x64Individual xunit test display names
Before:
GetModule_Succeeds(config: local/r2r)After:
GetModule_Succeeds(config: local/r2r, target: windows/x64)The dump source platform is read from
dump-info.json(which records the OS and architecture where dumps were generated). For local runs whereCDAC_DUMP_ROOTis not set, the display is unchanged.