Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,7 @@ public Blob ReserveBytes(int byteCount)
}

int start = ReserveBytesImpl(byteCount);
Array.Clear(_buffer, start, byteCount);
return new Blob(_buffer, start, byteCount);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -275,9 +275,8 @@ private void WritePEHeader(BlobBuilder builder, PEDirectoriesBuilder directories
builder.WriteUInt32((uint)BitArithmetic.Align(Header.ComputeSizeOfPEHeaders(sections.Length), Header.FileAlignment));

// Checksum:
// Shall be zero for strong name signing.
// Shall be zero for strong name signing, already zeroed by ReserveBytes.
_lazyChecksum = builder.ReserveBytes(sizeof(uint));
new BlobWriter(_lazyChecksum).WriteUInt32(0);

builder.WriteUInt16((ushort)Header.Subsystem);
builder.WriteUInt16((ushort)Header.DllCharacteristics);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,17 @@ public void ReserveBytes2()
}, blobs[0].GetBytes().ToArray());
}

[Fact]
public void ReserveBytes3()
{
var builder = new BlobBuilder(16);
builder.WriteBytes(0xff, 16);
builder.Clear();
// Reserved buffers must be zero-initialized.
var reserved = builder.ReserveBytes(4);
AssertEx.Equal(Enumerable.Repeat((byte)0, 4).ToArray(), reserved.GetBytes().ToArray());
}

// TODO:
// WriteBytes(byte*)
// WriteBytes(stream)
Expand Down
Loading