JIT: Unify to instParamLookup and improve GVM test coverage by hez2010 · Pull Request #126947 · dotnet/runtime

hez2010 · 2026-04-15T12:57:47Z

Extracted from #123323. This PR is the first step in splitting the shared GVM devirtualization work.

It does two things:

expands the generic virtual method test coverage so the later enablement PRs have good coverage
refactors devirtualization a bit to replace multiple ad-hoc flags in CORINFO_DEVIRTUALIZATION_INFO with a single instParamLookup

Contributes to #112596

/cc: @jakobbotsch

dotnet-policy-service · 2026-04-15T12:59:15Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

Refactors CoreCLR devirtualization metadata to use a unified instParamLookup and expands JIT test coverage for generic virtual method (GVM) scenarios to support follow-on GVM devirtualization work.

Changes:

Add a new GVM-focused runtime lookup/delegate test to broaden devirtualization coverage.
Replace CORINFO_DEVIRTUALIZATION_INFO ad-hoc flags with instParamLookup, and update JIT devirtualization logic to consume it.
Update SuperPMI and the managed JitInterface type definitions/serialization to match the new CORINFO_DEVIRTUALIZATION_INFO shape (plus bump the JIT/EE versioning GUID).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/tests/JIT/Generics/VirtualMethods/generic_virtual_methods.cs	Adds additional GVM/runtime-lookup-related test coverage.
src/coreclr/vm/jitinterface.cpp	Initializes/produces `instParamLookup` for devirtualization results (replacing older flags).
src/coreclr/jit/importercalls.cpp	Plumbs `instParamLookup` through devirtualization + guarded devirtualization candidate tracking and inserts instantiation args when required.
src/coreclr/jit/morph.cpp	Simplifies lookup-tree helpers to take `CORINFO_LOOKUP` directly.
src/coreclr/jit/compiler.h	Updates declarations for the new lookup-tree helper signatures and GDV candidate plumbing.
src/coreclr/inc/corinfo.h	Updates `CORINFO_DEVIRTUALIZATION_INFO` to carry `instParamLookup` instead of legacy flags; documents “no lookup needed” sentinel.
src/coreclr/inc/jiteeversionguid.h	Bumps the JIT/EE version GUID for the interface change.
src/coreclr/tools/Common/JitInterface/CorInfoTypes.cs	Mirrors the `CORINFO_DEVIRTUALIZATION_INFO` layout change in managed definitions.
src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs	Updates managed `resolveVirtualMethod` implementation to populate `instParamLookup` and method-context behavior.
src/coreclr/tools/superpmi/superpmi-shared/agnostic.h	Updates SuperPMI record structs to include `instParamLookup`.
src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp	Records/restores/dumps `instParamLookup` in SuperPMI method contexts.

hez2010 · 2026-04-16T03:28:30Z

Test failure seems unrelated.

hez2010 · 2026-04-24T04:28:04Z

Ping @jakobbotsch

This is a refactor only change which is the prerequisites of the upcoming GVM devirt work, please take a look when you get some time.

MichalPetryka · 2026-04-24T04:32:09Z

@MihuBot

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>

…m:hez2010/runtime into shared-gvm-devirt/1-tests-instparamlookup

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Copilot · 2026-04-25T14:48:46Z

    // If the guarded method is an instantiating stub, find the instantiated method
    //
-    if (instantiatingStub)
+    if (instantiatingStub != NO_METHOD_HANDLE)
    {
-        JITDUMP("    ... method is an instantiating stub, looking for instantiated entry\n");
-        CORINFO_CLASS_HANDLE  ignoredClass  = NO_CLASS_HANDLE;
-        CORINFO_METHOD_HANDLE ignoredMethod = NO_METHOD_HANDLE;
-        CORINFO_METHOD_HANDLE instantiatedMethod =
-            info.compCompHnd->getInstantiatedEntry(methodHandle, &ignoredMethod, &ignoredClass);
-        assert(ignoredClass == NO_CLASS_HANDLE);
-
-        if (instantiatedMethod != NO_METHOD_HANDLE)
-        {
-            JITDUMP("    ... updating GDV candidate with instantiated entry info\n");
-            pInfo->guardedMethodInstantiatedEntryHandle = instantiatedMethod;
-        }
+        JITDUMP("    ... updating GDV candidate with instantiated entry info\n");
+        pInfo->guardedMethodHandle                  = instantiatingStub;
+        pInfo->guardedMethodInstantiatedEntryHandle = methodHandle;


This comment says "find the instantiated method", but the code no longer calls getInstantiatedEntry (it just rewrites guardedMethodHandle / guardedMethodInstantiatedEntryHandle). Please update the comment to reflect the new semantics (e.g., that instantiatingStub is stored separately as the instantiation parameter / comparison target, while methodHandle remains the actual direct-call target).

Part 1: add tests and instParamLookup refactor

6120dec

hez2010 requested a review from MichalStrehovsky as a code owner April 15, 2026 12:57

Copilot AI review requested due to automatic review settings April 15, 2026 12:57

github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 15, 2026

Merge branch 'main' into shared-gvm-devirt/1-tests-instparamlookup

007d14f

dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Apr 15, 2026

Copilot started reviewing on behalf of hez2010 April 15, 2026 12:58 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread src/coreclr/vm/jitinterface.cpp

Comment thread src/coreclr/jit/importercalls.cpp Outdated

This was referenced Apr 22, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

browser-wasm linux Release LibraryTests queues timing out #117974

Open

MihuBot mentioned this pull request Apr 24, 2026

[JitDiff X64] [hez2010] JIT: Unify to instParamLookup and improve GVM test c ... MihuBot/runtime-utils#1850

Open

jakobbotsch reviewed Apr 24, 2026

View reviewed changes

Comment thread src/coreclr/inc/corinfo.h Outdated

Copilot AI review requested due to automatic review settings April 25, 2026 11:55

hez2010 force-pushed the shared-gvm-devirt/1-tests-instparamlookup branch from 75dec5b to 4da609f Compare April 25, 2026 11:55

Copilot started reviewing on behalf of hez2010 April 25, 2026 11:56 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread src/tests/JIT/Generics/VirtualMethods/generic_virtual_methods.cs

Comment thread src/coreclr/vm/jitinterface.cpp

Comment thread src/coreclr/jit/importercalls.cpp Outdated

Merge branch 'main' into shared-gvm-devirt/1-tests-instparamlookup

42d5011

hez2010 force-pushed the shared-gvm-devirt/1-tests-instparamlookup branch from 4da609f to 42d5011 Compare April 25, 2026 12:19

Address review feedbacks

e7acb94

Copilot AI review requested due to automatic review settings April 25, 2026 12:35

Copilot started reviewing on behalf of hez2010 April 25, 2026 12:36 View session

jakobbotsch reviewed Apr 25, 2026

View reviewed changes

Comment thread src/coreclr/jit/importercalls.cpp Outdated

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread src/tests/JIT/Generics/VirtualMethods/generic_virtual_methods.cs

Comment thread src/tests/JIT/Generics/VirtualMethods/generic_virtual_methods.cs

Comment thread src/coreclr/jit/compiler.h

jakobbotsch reviewed Apr 25, 2026

View reviewed changes

Comment thread src/coreclr/inc/corinfo.h Outdated

Update src/coreclr/inc/corinfo.h

eeb97f8

Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>

Copilot AI review requested due to automatic review settings April 25, 2026 12:59

hez2010 added 2 commits April 25, 2026 22:00

Use hasTypeArg instead of leaking CORINFO_LOOKUP

7dfc4f3

Merge branch 'shared-gvm-devirt/1-tests-instparamlookup' of github.co…

c3e08f2

…m:hez2010/runtime into shared-gvm-devirt/1-tests-instparamlookup

Copilot started reviewing on behalf of hez2010 April 25, 2026 13:00 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Comment thread src/tests/JIT/Generics/VirtualMethods/generic_virtual_methods.cs

Comment thread src/tests/JIT/Generics/VirtualMethods/generic_virtual_methods.cs

Switch back to needsMethodContext

5942cb8

Copilot AI review requested due to automatic review settings April 25, 2026 14:42

hez2010 force-pushed the shared-gvm-devirt/1-tests-instparamlookup branch from 2765090 to 5942cb8 Compare April 25, 2026 14:42

Copilot started reviewing on behalf of hez2010 April 25, 2026 14:43 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

jakobbotsch reviewed Apr 27, 2026

View reviewed changes

Comment thread src/coreclr/jit/importercalls.cpp

hez2010 mentioned this pull request Apr 27, 2026

JIT: Devirtualize shared generic virtual methods #123323

Draft

Merge branch 'main' into shared-gvm-devirt/1-tests-instparamlookup

7c8536e

This was referenced Apr 28, 2026

Android arm32 device not found (armeabi-v7a architecture unavailable) #125440

Open

[android] Got a SIGSEGV while executing native code. at System.DateTime.get_Now() #127500

Open

Conversation

hez2010 commented Apr 15, 2026

Uh oh!

dotnet-policy-service Bot commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

hez2010 commented Apr 16, 2026

Uh oh!

hez2010 commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichalPetryka commented Apr 24, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hez2010 commented Apr 24, 2026 •

edited

Loading