[cDAC] Add IMetaDataImport COM wrapper over MetadataReader for no-fallback mode#127028

Merged

max-charlamb merged 36 commits intomainfrom

cdac-metadata-import

Apr 27, 2026

Commits on Apr 24, 2026

Add IMetaDataImport COM wrapper over MetadataReader for cDAC no-fallback mode

Max Charlamb
and
Copilot
committed
Trim IMetaDataImport to consumer-used methods, add 8 new implementations

Max Charlamb
and
Copilot
committed
Refactor MetadataImportWrapper to follow cDAC fallback pattern

Max Charlamb
and
Copilot
committed
Remove CatchHR helper and inline try/catch blocks

Max Charlamb
and
Copilot
committed
Simplify catch blocks to match cDAC convention

Max Charlamb
and
Copilot
committed
Replace goto Done with thrown exception in EnumGenericParams

Max Charlamb
and
Copilot
committed
Rename MetadataImportWrapper to MetaDataImportImpl

Max Charlamb
and
Copilot
committed
Add legacy fallback to all unimplemented methods

Max Charlamb
and
Copilot
committed
Align MetaDataImportImpl with cDAC style conventions

Max Charlamb
and
Copilot
committed
Address PR review feedback

Max Charlamb
and
Copilot
committed
Add IMetaDataAssemblyImport support to MetaDataImportImpl

Max Charlamb
and
Copilot
committed
Fix premature return and expand DEBUG validation in IMetaDataAssemblyImport

Max Charlamb
and
Copilot
committed
Address PR review feedback

Max Charlamb
and
Copilot
committed
Remove GetInterface from no-fallback allowlist

Max Charlamb
and
Copilot
committed
Implement remaining PR review suggestions

Max Charlamb
and
Copilot
committed
Add comprehensive blob byte-level verification to #if DEBUG blocks

Max Charlamb
and
Copilot
committed
Return CLDB_S_TRUNCATION when string buffer is too small

Max Charlamb
and
Copilot
committed
Fix native semantic parity in MetaDataImport methods

Max Charlamb
and
Copilot
committed
Add tests for MetaDataImport semantic parity fixes

Max Charlamb
and
Copilot
committed
Add MetaDataImport dump-based integration tests

Max Charlamb
and
Copilot
committed
Fix GetUserString raw byte access and IMetaDataImport2 vtable overread

Max Charlamb
and
Copilot
committed
Fix MetaDataImportImpl double-QI vtable AV for EnumGenericParams

Max Charlamb
and
Copilot
committed
Remove null-forgiving operators from MetaDataImportImpl

Max Charlamb
and
Copilot
committed
Make MetadataReader a required parameter in MetaDataImportImpl

Max Charlamb
and
Copilot
committed
Fix dump test build: Assert.NotNull returns void in xUnit v2

Max Charlamb
and
Copilot
committed
Fix MetaDataImportImpl parity gaps: enum dispatch, field offsets, param lookup

Max Charlamb
and
Copilot
committed
Make _cdacEnumHandles thread-safe and use OutputBufferHelpers in assembly import methods

Max Charlamb
and
Copilot
committed
Add backward compat for integer contract versions in JSON descriptor

Max Charlamb
and
Copilot
committed
Revert "Add backward compat for integer contract versions in JSON descriptor"
Max Charlamb
committed
Address PR review feedback

Max Charlamb
and
Copilot
committed
Simplify COM interop: remove redundant QI and null-forgiving operator

Max Charlamb
and
Copilot
committed
Address PR review feedback (round 2)

Max Charlamb
and
Copilot
committed
Fix dump test build: use IMetaDataImport interface type

Max Charlamb
and
Copilot
committed
Remove unused using and fix misleading comment

Max Charlamb
and
Copilot
committed
Add CopyStringToBuffer overload with out bool truncated

Max Charlamb
and
Copilot
committed

Commits on Apr 27, 2026

comment nits
Max Charlamb
committed