Skip to content

[ios-clr] Preserve PDBs for CoreCLR and fix StackTrace tests on Apple mobile #127060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kotlarmilos wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[ios-clr] Preserve PDBs for CoreCLR and fix StackTrace tests on Apple mobile #127060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
21bc1bf
[ios-clr] Preserve PDBs for CoreCLR and fix StackTrace tests on Apple…
kotlarmilos Apr 17, 2026
421df86
Merge branch 'main' into ios-clr/pr-i-stacktrace-pdb
kotlarmilos Apr 20, 2026
ace9ec6
[ios-clr] Update stack trace file info pattern for Android mobile pla…
kotlarmilos Apr 20, 2026
849fae0
Update stack trace file info pattern for Android and Apple mobile pla…
kotlarmilos Apr 21, 2026
d4fd55b
Merge branch 'main' into ios-clr/pr-i-stacktrace-pdb
kotlarmilos Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libraries/System.Diagnostics.StackTrace/tests/DiagnosticMethodInfoTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public void Create_Null()
public static IEnumerable<object[]> Create_OpenDelegate_TestData()
{
// Tracked at https://github.com/dotnet/runtime/issues/100748
bool hasGvmOpenDelegateBug = !PlatformDetection.IsMonoRuntime && !PlatformDetection.IsNativeAot && !PlatformDetection.IsAppleMobile;
bool hasGvmOpenDelegateBug = !PlatformDetection.IsMonoRuntime && !PlatformDetection.IsNativeAot;
Comment thread
kotlarmilos marked this conversation as resolved.

const string TestNamespace = nameof(System) + "." + nameof(System.Diagnostics) + "." + nameof(System.Diagnostics.Tests) + ".";

Expand Down Expand Up @@ -71,6 +71,7 @@ public static IEnumerable<object[]> Create_OpenDelegate_TestData()
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))]
[MemberData(nameof(Create_OpenDelegate_TestData))]
public void Create_OpenDelegate(Delegate del, string expectedName, string expectedTypeName)
{
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public void Ctor_FNeedFileInfo(bool fNeedFileInfo)

[Theory]
[ActiveIssue("https://github.com/mono/mono/issues/15187", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile))]
[InlineData(StackFrame.OFFSET_UNKNOWN, true)]
[InlineData(0, true)]
Comment thread
kotlarmilos marked this conversation as resolved.
[InlineData(1, true)]
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,10 +603,10 @@ public void ToString_ShowILOffset_ByteArrayLoad()
}
}

// On Android, stack traces do not include file names and line numbers
// On Android and Apple mobile, stack traces do not include file names and line numbers
// Tracking issue: https://github.com/dotnet/runtime/issues/124087
private static string FileInfoPattern(string fileLinePattern) =>
PlatformDetection.IsAndroid ? "" : fileLinePattern;
PlatformDetection.IsAndroid || PlatformDetection.IsAppleMobile ? "" : fileLinePattern;

public static Dictionary<string, string[]> MethodExceptionStrings = new()
{
Expand Down
1 change: 0 additions & 1 deletion src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,6 @@
<!-- https://github.com/dotnet/runtime/issues/124344 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Composition\tests\System.Composition.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Loader\tests\System.Runtime.Loader.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Diagnostics.StackTrace\tests\System.Diagnostics.StackTrace.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Private.Xml\tests\System.Private.Xml.Tests.csproj" />

<!-- https://github.com/dotnet/runtime/issues/124344 -->
Expand Down
2 changes: 1 addition & 1 deletion src/tasks/AppleAppBuilder/Xcode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ public string GenerateCMake(
{
predefinedExcludes.Add(".dylib");
}
if (optimized)
if (optimized && targetRuntime != TargetRuntime.CoreCLR)
Comment thread
kotlarmilos marked this conversation as resolved.
{
predefinedExcludes.Add(".pdb");
}
Expand Down
Loading