Skip to content

Preserve invalid friend assembly diagnostics by removing lossy HRESULT roundtrip #127180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+33 −6
Draft

Preserve invalid friend assembly diagnostics by removing lossy HRESULT roundtrip #127180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80302f4
Initial plan
Copilot Apr 20, 2026
6e589e5
Preserve invalid friend assembly diagnostics by removing lossy HRESUL…
Copilot Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/coreclr/vm/assembly.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2590,12 +2590,8 @@ ReleaseHolder<FriendAssemblyDescriptor> FriendAssemblyDescriptor::CreateFriendAs
// Create an AssemblyNameObject from the string.
FriendAssemblyNameHolder pFriendAssemblyName;
pFriendAssemblyName = new FriendAssemblyName_t;
hr = pFriendAssemblyName->InitNoThrow(displayName);

if (SUCCEEDED(hr))
{
hr = pFriendAssemblyName->CheckFriendAssemblyName();
}
pFriendAssemblyName->Init(displayName);
hr = pFriendAssemblyName->CheckFriendAssemblyName();

if (FAILED(hr))
{
Expand Down
25 changes: 25 additions & 0 deletions ...sts/Loader/classloader/regressions/InvalidFriendAssemblyName/InvalidFriendAssemblyName.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.IO;
using System.Runtime.CompilerServices;
using Xunit;

[assembly: InternalsVisibleTo("Broken,PublicKey=00240000048000009400000006020000002400005253413100040000010001002d07581667cbf8caf9786ac8d5257eb2c77eb2643a1af1bb89d4286e27a3ff5d805408c9f1a0a392d2f478ca2b9c68e43cdcdcea2d7cf0618dd8ba48858bf5fc74c7fc2af7a29f936398c0f61a2165d08ac4fcc8e8ad04e24633b7ca31a7c13f750ae75e53cea55ced97d3289fd100dbe2661a802bf8bd2acb0b6893ef3fb79c,PublicKeyToken=282361b99ded7e8e")]

public class InvalidFriendAssemblyName
{
private const string InvalidAssemblyName = "Broken,PublicKey=00240000048000009400000006020000002400005253413100040000010001002d07581667cbf8caf9786ac8d5257eb2c77eb2643a1af1bb89d4286e27a3ff5d805408c9f1a0a392d2f478ca2b9c68e43cdcdcea2d7cf0618dd8ba48858bf5fc74c7fc2af7a29f936398c0f61a2165d08ac4fcc8e8ad04e24633b7ca31a7c13f750ae75e53cea55ced97d3289fd100dbe2661a802bf8bd2acb0b6893ef3fb79c,PublicKeyToken=282361b99ded7e8e";

[Fact]
public static void TestEntryPoint()
{
FileLoadException exception = Assert.Throws<FileLoadException>(() => new InvalidFriendAssemblyName().GetCopy());

Assert.Equal(InvalidAssemblyName, exception.FileName);
Assert.Contains("assembly name was invalid", exception.Message, StringComparison.OrdinalIgnoreCase);
}

public object GetCopy() => MemberwiseClone();
}
6 changes: 6 additions & 0 deletions ...Loader/classloader/regressions/InvalidFriendAssemblyName/InvalidFriendAssemblyName.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<ItemGroup>
<Compile Include="InvalidFriendAssemblyName.cs" />
<ProjectReference Include="$(TestLibraryProjectPath)" />
</ItemGroup>
</Project>
Loading