Remove RSA guard for OSSL#127192
Merged
steveisok merged 3 commits intodotnet:mainfrom Apr 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates OpenSSL feature detection to avoid compilation failures when probing deprecated RSA APIs during CMake configuration (fixing the reported Mono build break on linux bionic arm64).
Changes:
- Switch RSA legacy API detection from a
check_source_compilessnippet (including<openssl/rsa.h>) tocheck_function_exists(RSA_new). - Keep
HAVE_OPENSSL_RSA_PRIMITIVEfeature flag generation intact while making the probe less header-sensitive.
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 21, 2026
Open
Open
Member
|
/azp run runtime-linuxbionic |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-linuxbionic |
|
Azure Pipelines successfully started running 1 pipeline(s). |
steveisok
approved these changes
Apr 21, 2026
Member
|
Weird, not sure what's up with the linux-bionic pipeline. |
Member
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/ba-g Unrealted failures - prioritizing merge to unblock the VMR build. |
PranavSenthilnathan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127154
Removes the check for deprecated RSA APIs. This was intended to detect if the APIs were removed in some future version of OSSL but the Linux build isn't detecting it correctly. Since all the OSSL versions currently still have the APIs, it's safe to remove the guard to unlock the build.