Skip to content

Remove unwind calls from patchpoint OSR transition#127213

Merged
jakobbotsch merged 29 commits intodotnet:mainfrom
am11:feature/osr-jit-transition2
Apr 28, 2026
Merged

Remove unwind calls from patchpoint OSR transition#127213
jakobbotsch merged 29 commits intodotnet:mainfrom
am11:feature/osr-jit-transition2

Conversation

@am11
Copy link
Copy Markdown
Member

@am11 am11 commented Apr 21, 2026

Follow-up on #123645 (comment).

@am11 am11 requested a review from jakobbotsch April 21, 2026 09:54
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 21, 2026
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Apr 21, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Comment thread src/coreclr/jit/codegencommon.cpp Outdated
Comment thread src/coreclr/jit/patchpoint.cpp Outdated
Comment thread src/coreclr/jit/codegencommon.cpp
Comment thread src/coreclr/jit/codegencommon.cpp Outdated
Comment thread src/coreclr/jit/codegencommon.cpp Outdated
Comment thread src/coreclr/jit/codegencommon.cpp
Comment thread src/coreclr/jit/codegencommon.cpp Outdated
Comment thread src/coreclr/vm/jithelpers.cpp Outdated
@am11
Copy link
Copy Markdown
Member Author

am11 commented Apr 23, 2026

@jakobbotsch, I've addressed feedback and merged main (which has your changes).

@jakobbotsch
Copy link
Copy Markdown
Member

/azp run runtime-jit-experimental

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch
Copy link
Copy Markdown
Member

Looks like there are some failures

Comment thread src/coreclr/jit/lower.cpp
Comment thread src/coreclr/jit/codegencommon.cpp
am11 and others added 2 commits April 24, 2026 12:55
Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
@am11
Copy link
Copy Markdown
Member Author

am11 commented Apr 24, 2026

@jakobbotsch, could you please rerun priority 1 tests against this PR? (just in case there is still something missing)

@jakobbotsch
Copy link
Copy Markdown
Member

/azp run runtime-jit-experimental

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@am11
Copy link
Copy Markdown
Member Author

am11 commented Apr 25, 2026

Timeout is unrelated. @jakobbotsch, is there anything else needed for this PR?

Copy link
Copy Markdown
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndyAyersMS can you also take a look? #127384 already incorporates the docs updates for this scheme.

cc @dotnet/jit-contrib

@jakobbotsch jakobbotsch requested a review from AndyAyersMS April 25, 2026 16:17
Comment thread src/coreclr/vm/jithelpers.cpp
Comment thread src/coreclr/jit/codegencommon.cpp
am11 and others added 2 commits April 27, 2026 13:42
Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
@jakobbotsch jakobbotsch merged commit 0b6bb45 into dotnet:main Apr 28, 2026
140 checks passed
@jakobbotsch
Copy link
Copy Markdown
Member

Thanks!

@am11 am11 deleted the feature/osr-jit-transition2 branch April 28, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants