Skip to content

Mark Continuation field accessors as AggressiveInlining #127227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 2 commits into from
Apr 21, 2026
Merged

Mark Continuation field accessors as AggressiveInlining #127227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a602fd
Mark Continuation field accessors as `AggressiveInlining`
jakobbotsch Apr 21, 2026
fb2bd73
Also SetException
jakobbotsch Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...oreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ internal unsafe class Continuation

// See note in ContinuationFlags above for the computation of these offsets.

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public unsafe object GetContinuationContext()
{
const uint mask = (1u << (int)ContinuationFlags.ContinuationContextIndexNumBits) - 1;
Expand All @@ -120,12 +121,14 @@ public unsafe object GetContinuationContext()
return Unsafe.As<byte, object>(ref Unsafe.Add(ref data, (DataOffset - PointerSize) + index * PointerSize));
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public bool HasException()
{
const uint mask = (1u << (int)ContinuationFlags.ExceptionIndexNumBits) - 1;
return ((uint)Flags & (mask << (int)ContinuationFlags.ExceptionIndexFirstBit)) != 0;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public void SetException(Exception ex)
{
const uint mask = (1u << (int)ContinuationFlags.ExceptionIndexNumBits) - 1;
Expand All @@ -135,6 +138,7 @@ public void SetException(Exception ex)
Unsafe.As<byte, Exception>(ref Unsafe.Add(ref data, (DataOffset - PointerSize) + index * PointerSize)) = ex;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public ref byte GetResultStorageOrNull()
{
const uint mask = (1u << (int)ContinuationFlags.ResultIndexNumBits) - 1;
Expand Down
Loading