-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add a fluent Validate overload for adding validator types
#127264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cincuranet
merged 12 commits into
dotnet:main
from
89netraM:feature/options-builder-validator-type
Apr 27, 2026
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cc1abed
Add a Validate overload for adding validator types
89netraM 302b2fe
Add new Validate overload to Options ref
89netraM 050fae3
Test IValidateOptions types with dependencies
89netraM 1fdf046
Verify that validators applies regardless of name
89netraM ad98392
Add name filter to validators from OptionsBuilder
89netraM 8f9a28b
Fix name-scoped validator registration test
89netraM 184d33b
Make `NamedValidateOptionsFilter` sealed
89netraM d611e1b
Definitively test that scoped validators are run
89netraM 3266253
Add remarks to `Validate` overload
89netraM 6cff367
Remove redundant initialization
89netraM c981bb1
Never filter out `null` named options
89netraM 4dd7333
Update examples to use the new `Validate` overload
89netraM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
src/libraries/Microsoft.Extensions.Options/src/NamedValidateOptionsFilter.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
|
|
||
| namespace Microsoft.Extensions.Options | ||
| { | ||
| internal sealed class NamedValidateOptionsFilter<TOptions, TInner> : IValidateOptions<TOptions> | ||
| where TOptions : class | ||
| where TInner : IValidateOptions<TOptions> | ||
| { | ||
| private readonly string _name; | ||
| private readonly TInner _inner; | ||
|
|
||
| internal NamedValidateOptionsFilter(string name, TInner inner) | ||
| { | ||
| ArgumentNullException.ThrowIfNull(inner); | ||
|
|
||
| _name = name; | ||
| _inner = inner; | ||
| } | ||
|
|
||
| public ValidateOptionsResult Validate(string? name, TOptions options) | ||
| { | ||
| if (name is null || name == _name) | ||
| { | ||
| return _inner.Validate(name, options); | ||
| } | ||
|
|
||
| // ignored if not validating this instance | ||
| return ValidateOptionsResult.Skip; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.