Skip to content

[browser] Enable StackTraceLineNumberSupport in StackTrace tests #127280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maraf merged 7 commits into from
Apr 26, 2026
Merged

[browser] Enable StackTraceLineNumberSupport in StackTrace tests #127280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
43abee4
Enable StackTraceLineNumberSupport for browser in StackTrace tests
maraf Apr 22, 2026
77706c8
Add unset guard to StackTraceLineNumberSupport condition
maraf Apr 22, 2026
073f2b8
Re-enable browser/CoreCLR test suites with targeted test skips
maraf Apr 24, 2026
b748a47
Revert "Re-enable browser/CoreCLR test suites with targeted test skips"
maraf Apr 24, 2026
b0e3be4
Merge remote-tracking branch 'origin/main' into enable-stacktrace-lin…
maraf Apr 24, 2026
6ce3ebe
Enable StackTrace tests on browser now that line number support is en…
maraf Apr 24, 2026
372851b
Re-add [ActiveIssue] on ToString_Async for browser
maraf Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/System.Diagnostics.StackTrace/tests/StackFrameExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public static IEnumerable<object[]> HasMethod_TestData()
}

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsILOffsetsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
[MemberData(nameof(HasMethod_TestData))]
public void HasILOffset_Invoke_ReturnsExpected(StackFrame stackFrame, bool expected)
{
Expand All @@ -58,7 +58,7 @@ public void HasILOffset_NullStackFrame_ThrowsNullReferenceException()
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/103218", typeof(PlatformDetection), nameof(PlatformDetection.IsNativeAot))]
[MemberData(nameof(HasMethod_TestData))]
public void HasMethod_Invoke_ReturnsExpected(StackFrame stackFrame, bool expected)
Expand Down
8 changes: 4 additions & 4 deletions src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ public void OffsetUnknown_Get_ReturnsNegativeOne()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
public void Ctor_Default()
{
var stackFrame = new StackFrame();
VerifyStackFrame(stackFrame, false, 0, typeof(StackFrameTests).GetMethod(nameof(Ctor_Default)), isCurrentFrame: true);
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
[InlineData(true)]
[InlineData(false)]
public void Ctor_FNeedFileInfo(bool fNeedFileInfo)
Expand All @@ -51,7 +51,7 @@ public void Ctor_SkipFrames_FNeedFileInfo(int skipFrames, bool fNeedFileInfo)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
public void SkipFrames_CallMethod_ReturnsExpected()
{
StackFrame stackFrame = CallMethod(1);
Expand All @@ -73,7 +73,7 @@ public void SkipFrames_ManyFrames_HasNoMethod(int skipFrames)
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
[InlineData(null, StackFrame.OFFSET_UNKNOWN)]
[InlineData("", 0)]
[InlineData("FileName", 1)]
Expand Down
14 changes: 7 additions & 7 deletions src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,15 +221,15 @@ public void MethodsToSkip_Get_ReturnsZero()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
public void Ctor_Default()
Comment thread
maraf marked this conversation as resolved.
{
var stackTrace = new StackTrace();
VerifyFrames(stackTrace, false, 0);
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
[InlineData(true)]
[InlineData(false)]
public void Ctor_FNeedFileInfo(bool fNeedFileInfo)
Expand All @@ -239,7 +239,7 @@ public void Ctor_FNeedFileInfo(bool fNeedFileInfo)
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
[InlineData(0)]
[InlineData(1)]
public void Ctor_SkipFrames(int skipFrames)
Expand All @@ -263,7 +263,7 @@ public void Ctor_LargeSkipFrames_GetFramesReturnsEmpty()
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
[InlineData(0, true)]
[InlineData(1, true)]
[InlineData(0, false)]
Expand Down Expand Up @@ -291,7 +291,7 @@ public void Ctor_LargeSkipFramesFNeedFileInfo_GetFramesReturnsEmpty(bool fNeedFi
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
public void Ctor_ThrownException_GetFramesReturnsExpected()
{
var stackTrace = new StackTrace(InvokeException());
Expand All @@ -309,7 +309,7 @@ public void Ctor_EmptyException_GetFramesReturnsEmpty()
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
[InlineData(true)]
[InlineData(false)]
public void Ctor_Bool_ThrownException_GetFramesReturnsExpected(bool fNeedFileInfo)
Expand All @@ -332,7 +332,7 @@ public void Ctor_EmptyException_FNeedFileInfo(bool fNeedFileInfo)

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/31796", TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50957", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoAOT))]
[InlineData(0)]
[InlineData(1)]
public void Ctor_Exception_SkipFrames(int skipFrames)
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Diagnostics.StackTrace/tests/System.Diagnostics.StackTrace.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

<!-- these tests depend on the pdb files -->
<DebuggerSupport Condition="'$(DebuggerSupport)' == '' and '$(TargetOS)' == 'browser'">true</DebuggerSupport>
<StackTraceLineNumberSupport Condition="'$(StackTraceLineNumberSupport)' == '' and '$(TargetOS)' == 'browser'">true</StackTraceLineNumberSupport>
<!-- https://github.com/dotnet/runtime/issues/126862 -->
<EnableTrimAnalyzer>false</EnableTrimAnalyzer>
<EnableAotAnalyzer>false</EnableAotAnalyzer>
Expand Down
Loading