Skip to content

Remove Unused Includes #127295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
moyo1997 wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Remove Unused Includes #127295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0705f85
attempt 1
moyo1997 Apr 22, 2026
dcb5d41
fix
moyo1997 Apr 22, 2026
a515ddd
fix
moyo1997 Apr 22, 2026
ec6bd1b
fix
moyo1997 Apr 22, 2026
1e81e2e
fix
moyo1997 Apr 22, 2026
75bc1cd
fix
moyo1997 Apr 22, 2026
4c538cf
fix
moyo1997 Apr 22, 2026
b451689
fix
moyo1997 Apr 22, 2026
718915a
fix
moyo1997 Apr 22, 2026
3c38690
fixes
moyo1997 Apr 23, 2026
2c210d3
fixes
moyo1997 Apr 23, 2026
fe05e15
fix
moyo1997 Apr 23, 2026
1b3d1f6
fix
moyo1997 Apr 23, 2026
c97aa65
fix
moyo1997 Apr 23, 2026
0c2345f
comments
moyo1997 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/coreclr/binder/assembly.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
// ============================================================
#include "common.h"
#include "assembly.hpp"
#include "utils.hpp"
#include "assemblybindercommon.hpp"

namespace BINDER_SPACE
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/debug/daccess/dacfn.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include <virtualcallstub.h>
#include "peimagelayout.inl"

#include "gcinterface.h"
#include "gcinterface.dac.h"
struct DacHostVtPtrs
{
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/debug/debug-pal/win/processdescriptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

#include <windows.h>
#include <stdio.h>
#include <wchar.h>
#include <assert.h>
#include "processdescriptor.h"

ProcessDescriptor ProcessDescriptor::FromCurrentProcess()
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/debug/di/dbgtransportmanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// The .NET Foundation licenses this file to you under the MIT license.

#include "stdafx.h"
#include "dbgtransportsession.h"
#include "dbgtransportmanager.h"
#include "dbgtransportsession.h"
Comment on lines 5 to +6
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbgtransportmanager.h refers to DbgTransportSession but does not forward declare or include it. This .cpp used to include dbgtransportsession.h before dbgtransportmanager.h to satisfy that dependency; the new include order will cause DbgTransportSession to be an unknown type when compiling this file. Fix by either restoring the original include order here, or (preferably) making dbgtransportmanager.h self-contained by adding a forward declaration for DbgTransportSession (and any other needed types) and including the full header only where required.

Suggested change
#include "dbgtransportmanager.h"
#include "dbgtransportsession.h"
#include "dbgtransportsession.h"
#include "dbgtransportmanager.h"

Copilot uses AI. Check for mistakes.

#ifdef FEATURE_DBGIPC_TRANSPORT_DI

Expand Down
1 change: 0 additions & 1 deletion src/coreclr/debug/ee/amd64/walker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "walker.h"

#include "frames.h"
#include "openum.h"
#include "amd64InstrDecode.h"

#ifdef TARGET_AMD64
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/debug/ee/dactable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#include "../../vm/codeman.h"
#include "../../vm/eedbginterfaceimpl.h"
#include "../../vm/common.h"
#include "../../vm/gcenv.h"
#include "../../vm/ecall.h"
#include "../../vm/cdacplatformmetadata.hpp"

Expand Down
1 change: 0 additions & 1 deletion src/coreclr/debug/ee/debuggermodule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include "eeconfig.h" // This is here even for retail & free builds...
#include "vars.hpp"
#include <limits.h>
#include "ilformatter.h"
#include "debuginfostore.h"


Expand Down
1 change: 0 additions & 1 deletion src/coreclr/debug/ee/funceval.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#include "threads.h"
#include "appdomain.inl"
#include <limits.h>
#include "ilformatter.h"

#ifndef DACCESS_COMPILE

Expand Down
1 change: 0 additions & 1 deletion src/coreclr/dlls/mscorpe/ceefilegenwriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include <limits.h>

#include "corerror.h"
#include <posterror.h>

// The following block contains a template for the default entry point stubs of a CLR
// IL only program. One can emit these stubs (with some fix-ups) and make
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/gc/vxsort/do_vxsort_avx2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ void do_vxsort_avx2 (uint8_t** low, uint8_t** high, uint8_t* range_low, uint8_t*
auto sorter = vxsort::vxsort<int64_t, vxsort::vector_machine::AVX2, 8, shift>();
sorter.sort ((int64_t*)low, (int64_t*)high, (int64_t)range_low, (int64_t)(range_high+sizeof(uint8_t*)));
}
#include "vxsort_targets_disable.h"
#include "vxsort_targets_disable.h"
2 changes: 1 addition & 1 deletion src/coreclr/gc/vxsort/do_vxsort_avx512.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ void do_vxsort_avx512 (uint8_t** low, uint8_t** high, uint8_t* range_low, uint8_
auto sorter = vxsort::vxsort<int64_t, vxsort::vector_machine::AVX512, 8, shift>();
sorter.sort ((int64_t*)low, (int64_t*)high, (int64_t)range_low, (int64_t)(range_high+sizeof(uint8_t*)));
}
#include "vxsort_targets_disable.h"
#include "vxsort_targets_disable.h"
1 change: 0 additions & 1 deletion src/coreclr/gcinfo/arraylist.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ extern "C" void assertAbort(const char* why, const char* file, unsigned line);
#define _ASSERTE(expr) (void)0
#endif // _DEBUG

#include "gcinfohelpers.h"
#include <stdint.h>
#include "contract.h"
#include "iallocator.h"
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/ildasm/dres.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "dasmenum.hpp"
#include "formattype.h"
#include "dis.h"
#include "resource.h"
#include "ilformatter.h"
#include "outstring.h"

Expand Down
1 change: 0 additions & 1 deletion src/coreclr/ildasm/ildasmpch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@

//
// This is just to build the PCH for ildasm
#include "ildasmpch.h"
1 change: 0 additions & 1 deletion src/coreclr/ildasm/windasm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
************************************************************************************************/
#include "ildasmpch.h"

#include "dynamicarray.h"

#include "dasmenum.hpp"
#include "dis.h"
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/interop/interoplib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
#include "platform.h"
#include <interoplib.h>
#include <interoplibabi.h>
#include <interoplibimports.h>

#ifdef FEATURE_COMWRAPPERS
#include "comwrappers.hpp"
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/jit/block.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
#pragma hdrstop
#endif

#include "jitstd/algorithm.h"

#if MEASURE_BLOCK_SIZE
/* static */
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/jit/dllmain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#pragma hdrstop
#endif
#include "emit.h"
#include "corexcep.h"

#ifndef DLLEXPORT
#define DLLEXPORT
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/jit/ee_il_dll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
#pragma hdrstop
#endif
#include "emit.h"
#include "corexcep.h"

#if !defined(HOST_UNIX)
#include <io.h> // For _dup, _setmode
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/jit/importer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
#pragma hdrstop
#endif

#include "corexcep.h"

/*****************************************************************************
*
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/jit/loopcloning.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
*/

#include "jitpch.h"
#include "jitstd/algorithm.h"

#ifdef DEBUG

Expand Down
1 change: 0 additions & 1 deletion src/coreclr/jit/promotion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@

#include "jitpch.h"
#include "promotion.h"
#include "jitstd/algorithm.h"

//------------------------------------------------------------------------
// PhysicalPromotion: Promote structs based on primitive access patterns.
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/jit/promotiondecomposition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@

#include "jitpch.h"
#include "promotion.h"
#include "jitstd/algorithm.h"

// Represents a list of statements; this is the result of store decomposition.
class DecompositionStatementList
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/jit/simdcodegenxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
#include "sideeffects.h"
#include "lower.h"
#include "gcinfo.h"
#include "gcinfoencoder.h"

//-----------------------------------------------------------------------------
// genStoreIndTypeSimd12: store indirect a TYP_SIMD12 (i.e. Vector3) to memory.
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/md/compiler/custattr_import.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
#include "rwutil.h"
#include "mdlog.h"
#include "importhelper.h"
#include "posterror.h"
#include "cahlprinternal.h"
#include "custattr.h"
#include "corhdr.h"
#include <metamodelrw.h>
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/md/compiler/regmeta.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#include "importhelper.h"
#include "filtermanager.h"
#include "switches.h"
#include "posterror.h"
#include "stgio.h"
#include "sstring.h"
#include <minipal/guid.h>
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/md/compiler/regmeta_compilersupport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,8 @@
#include "mdutil.h"
#include "rwutil.h"
#include "mdlog.h"
#include "importhelper.h"
#include "filtermanager.h"
#include "switches.h"
#include "posterror.h"
#include "stgio.h"
#include "sstring.h"

Expand Down
1 change: 0 additions & 1 deletion src/coreclr/md/compiler/regmeta_emit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "importhelper.h"
#include "filtermanager.h"
#include "switches.h"
#include "posterror.h"
#include "stgio.h"
#include "sstring.h"

Expand Down
1 change: 0 additions & 1 deletion src/coreclr/md/compiler/regmeta_import.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#include "importhelper.h"
#include "filtermanager.h"
#include "switches.h"
#include "posterror.h"
#include "stgio.h"
#include "sstring.h"

Expand Down
1 change: 0 additions & 1 deletion src/coreclr/md/compiler/regmeta_vm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "importhelper.h"
#include "filtermanager.h"
#include "switches.h"
#include "posterror.h"
#include "stgio.h"
#include "sstring.h"

Expand Down
1 change: 0 additions & 1 deletion src/coreclr/md/enc/stgtiggerstream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "stdafx.h"
#include "stgtiggerstream.h"
#include "stgtiggerstorage.h"
#include "posterror.h"

//
//
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/md/runtime/mdinternaldisp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include "stdafx.h"
#include "mdinternaldisp.h"
#include "mdinternalro.h"
#include "posterror.h"
#include "corpriv.h"
#include "pedecoder.h"
#include "metamodel.h"
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/minipal/Windows/memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

#include <windows.h>
#include <inttypes.h>
#include <assert.h>
#include <malloc.h>
#include "minipal.h"

Expand Down
1 change: 0 additions & 1 deletion src/coreclr/nativeaot/Runtime/AsmOffsetsVerify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#include "gcheaputilities.h"
#include "rhassert.h"
#include "slist.h"
#include "regdisplay.h"
#include "StackFrameIterator.h"
#include "thread.h"
#include "TargetPtrs.h"
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/nativeaot/Runtime/Crst.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#include "common.h"
#include "CommonTypes.h"
#include "CommonMacros.h"
#include "PalLimitedContext.h"
#include "Pal.h"
#include "holder.h"
#include "Crst.h"
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/nativeaot/Runtime/DebugHeader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include "Pal.h"
#include "holder.h"
#include "RuntimeInstance.h"
#include "regdisplay.h"
#include "StackFrameIterator.h"
#include "thread.h"
#include "threadstore.h"
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/nativeaot/Runtime/EHHelpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "holder.h"
#include "Crst.h"
#include "RuntimeInstance.h"
#include "event.h"
#include "regdisplay.h"
#include "StackFrameIterator.h"
#include "thread.h"
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/nativeaot/Runtime/FinalizerHelpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "RuntimeInstance.h"
#include "shash.h"

#include "regdisplay.h"
#include "StackFrameIterator.h"

#include "thread.h"
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/nativeaot/Runtime/GCHelpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

#include "PalLimitedContext.h"
#include "slist.h"
#include "regdisplay.h"
#include "StackFrameIterator.h"
#include "interoplibinterface.h"

Expand Down
4 changes: 0 additions & 4 deletions src/coreclr/nativeaot/Runtime/GcStressControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,14 @@
#include "CommonTypes.h"
#include "CommonMacros.h"
#include "daccess.h"
#include "PalLimitedContext.h"
#include "Pal.h"
#include "rhassert.h"
#include "holder.h"
#include "Crst.h"
#include "RhConfig.h"
#include "slist.h"
#include "regdisplay.h"
#include "forward_declarations.h"
#include "StackFrameIterator.h"
#include "thread.h"
#include "event.h"
#include "threadstore.h"
#include "threadstore.inl"
#include "shash.h"
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/nativeaot/Runtime/HandleTableHelpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#include "objecthandle.h"
#include "RestrictedCallouts.h"
#include "gchandleutilities.h"
#include "interoplibinterface.h"


FCIMPL2(OBJECTHANDLE, RhpHandleAlloc, Object *pObject, int type)
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/nativeaot/Runtime/MathHelpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
#include "common.h"
#include "CommonTypes.h"
#include "CommonMacros.h"
#include "rhassert.h"

Expand Down
5 changes: 0 additions & 5 deletions src/coreclr/nativeaot/Runtime/MiscHelpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@
#include "Crst.h"
#include "rhbinder.h"
#include "RuntimeInstance.h"
#include "regdisplay.h"
#include "StackFrameIterator.h"
#include "thread.h"
#include "event.h"
#include "threadstore.h"
#include "threadstore.inl"
#include "thread.inl"
Expand All @@ -30,12 +28,9 @@
#include "ObjectLayout.h"
#include "MethodTable.inl"
#include "CommonMacros.inl"
#include "volatile.h"
#include "yieldprocessornormalized.h"
#include "RhConfig.h"
#include <minipal/cpuid.h>
#include <minipal/debugger.h>
#include <minipal/time.h>

FCIMPL0(void, RhDebugBreak)
{
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/nativeaot/Runtime/RestrictedCallouts.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "MethodTable.h"
#include "ObjectLayout.h"
#include "event.h"
#include "regdisplay.h"
#include "StackFrameIterator.h"
#include "thread.h"
#include "threadstore.h"
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/nativeaot/Runtime/RuntimeInstance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
#include "Crst.h"
#include "rhbinder.h"
#include "RuntimeInstance.h"
#include "event.h"
#include "regdisplay.h"
#include "StackFrameIterator.h"
#include "thread.h"
#include "threadstore.h"
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/nativeaot/Runtime/SyncClean.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
#include "CommonTypes.h"
#include "CommonMacros.h"
#include "daccess.h"
#include "PalLimitedContext.h"
#include "Pal.h"
#include "rhassert.h"
#include "slist.h"
#include "holder.h"
Expand Down
Loading
Loading