Skip to content

[SRM] Optimize building the blob heap. #127304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teo-tsirpanis wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[SRM] Optimize building the blob heap. #127304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9480359
Optimize memory usage when building the blob heap.
teo-tsirpanis Apr 22, 2026
4064724
Address Copilot feedback.
teo-tsirpanis Apr 22, 2026
6cb03db
Fix typos.
teo-tsirpanis Apr 23, 2026
40cf6f1
Free the placeholder empty head chunk after having finished writing t…
teo-tsirpanis Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libraries/System.Reflection.Metadata/src/System.Reflection.Metadata.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
Expand Down Expand Up @@ -49,6 +49,7 @@ The System.Reflection.Metadata library is built-in as part of the shared framewo
<Compile Include="System\Reflection\Metadata\BlobWriterImpl.cs" />
<Compile Include="System\Reflection\Metadata\BlobBuilder.cs" />
<Compile Include="System\Reflection\Metadata\BlobBuilder.Enumerators.cs" />
<Compile Include="System\Reflection\Metadata\BlobBuilder.Segment.cs" />
<Compile Include="System\Reflection\Internal\Utilities\DecimalUtilities.cs" />
<Compile Include="System\Reflection\Internal\Utilities\EnumerableExtensions.cs" />
<Compile Include="System\Reflection\Metadata\Ecma335\CustomAttributeDecoder.cs" />
Expand Down
17 changes: 11 additions & 6 deletions src/libraries/System.Reflection.Metadata/src/System/Reflection/Internal/Utilities/Hash.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Collections.Immutable;

namespace System.Reflection.Internal
{
internal static class Hash
Expand Down Expand Up @@ -40,13 +38,20 @@ internal static int Combine(bool newKeyPart, int currentKey)
/// </summary>
/// <param name="data">The sequence of bytes</param>
/// <returns>The FNV-1a hash of <paramref name="data"/></returns>
internal static int GetFNVHashCode(ReadOnlySpan<byte> data)
{
int hashCode = Hash.FnvOffsetBias;
internal static int GetFNVHashCode(ReadOnlySpan<byte> data) => AccumulateFNVHashCode(FnvOffsetBias, data);

/// <summary>
/// Compute the FNV-1a hash of a sequence of bytes
/// See http://en.wikipedia.org/wiki/Fowler%E2%80%93Noll%E2%80%93Vo_hash_function
/// </summary>
/// <param name="hashCode">The current hash code</param>
/// <param name="data">The sequence of bytes</param>
/// <returns>The updated hash code</returns>
internal static int AccumulateFNVHashCode(int hashCode, ReadOnlySpan<byte> data)
{
for (int i = 0; i < data.Length; i++)
{
hashCode = unchecked((hashCode ^ data[i]) * Hash.FnvPrime);
hashCode = unchecked((hashCode ^ data[i]) * FnvPrime);
}

return hashCode;
Expand Down
Loading
Loading