P/Invoke transient IL regression fixes#127400
Merged
jkotas merged 8 commits intodotnet:mainfrom Apr 28, 2026
Merged
Conversation
…g on inlining decisions. Update handling to understand this case.
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CoreCLR P/Invoke regressions related to transient IL by correcting x86 stack-argument sizing behavior during stub generation and adjusting PInvokeImportWorker to handle additional runtime call paths / GC modes without contract violations.
Changes:
- Ensure x86 stack argument size computation initializes per-argument native sizes via
MarshalInfo::SetupArgumentSizes(). - Update
PInvokeImportWorkerto allow cooperative-mode callers forSuppressGCTransitionscenarios and avoid resolving targets when already resolved. - Limit managed exception dispatcher / unwind handler installation to the resolution path.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jkotas
reviewed
Apr 24, 2026
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
reviewed
Apr 24, 2026
jkotas
reviewed
Apr 24, 2026
jkotas
reviewed
Apr 25, 2026
…ions get thrown first) but before jitting (so we don't cache the code pointer before resolving the target for SuppressGCTransition P/Invokes.
jkotas
reviewed
Apr 27, 2026
…rt-thunk into a more shared location
jkotas
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127231
Fixes #127209