Skip to content

[wasm][coreclr] Enable priority1 runtime tests in outerloop#127438

Open
radekdoulik wants to merge 4 commits intodotnet:mainfrom
radekdoulik:wasm-coreclr-rt-outerloop
Open

[wasm][coreclr] Enable priority1 runtime tests in outerloop#127438
radekdoulik wants to merge 4 commits intodotnet:mainfrom
radekdoulik:wasm-coreclr-rt-outerloop

Conversation

@radekdoulik
Copy link
Copy Markdown
Member

Disable few more MT tests

Decorate and exclude failing tests

Disable few more MT tests

Decorate and exclude failing tests
@radekdoulik radekdoulik added this to the Future milestone Apr 26, 2026
@radekdoulik radekdoulik added the arch-wasm WebAssembly architecture label Apr 26, 2026
Copilot AI review requested due to automatic review settings April 26, 2026 19:31
@radekdoulik
Copy link
Copy Markdown
Member Author

/azp run ci

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

@radekdoulik
Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr-outerloop

@azure-pipelines
Copy link
Copy Markdown

No pipelines are associated with this pull request.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CoreCLR/wasm outerloop coverage by adding a browser-wasm checked build + outerloop runtime test run to the CoreCLR CI pipeline, while suppressing known-failing scenarios on Browser/wasm and non-multithreaded environments.

Changes:

  • Add browser_wasm checked build artifact production and a corresponding outerloop runtime test run to eng/pipelines/coreclr/ci.yml.
  • Gate several multithreading-dependent tests with ConditionalFact(...IsMultithreadingSupported) and add required TestLibrary references.
  • Exclude/disable specific known-failing tests on Browser/wasm (ActiveIssue + conditional Compile/MergedWrapperProjectReference removals).

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
eng/pipelines/coreclr/ci.yml Adds browser-wasm checked build + outerloop test run jobs for CoreCLR CI.
src/tests/Loader/classloader/MethodImpl/Desktop/self_override5.il Adds Browser-only ActiveIssue to disable a known failing loader test on Browser.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_add.cs Gates test on multithreading support via ConditionalFact.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_sub.cs Gates test on multithreading support via ConditionalFact.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_mul.cs Gates test on multithreading support via ConditionalFact.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_div.cs Gates test on multithreading support via ConditionalFact.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_mod.cs Gates test on multithreading support via ConditionalFact.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_xor.cs Gates test on multithreading support via ConditionalFact.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_or.cs Gates test on multithreading support via ConditionalFact.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_and.cs Gates test on multithreading support via ConditionalFact.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_shr.cs Gates test on multithreading support via ConditionalFact.
src/tests/JIT/jit64/opt/cse/VolatileTest.csproj Adds TestLibrary project reference to support new PlatformDetection usage.
src/tests/JIT/Methodical/Methodical_ro.csproj Excludes a known failing callconv test on Browser via Condition.
src/tests/JIT/Methodical/Methodical_do.csproj Excludes a known failing callconv test on Browser via Condition.
src/tests/JIT/Methodical/Methodical_r2.csproj Removes specific wrapper test projects on Browser and excludes call.cs via Condition.
src/tests/JIT/Methodical/Methodical_d2.csproj Removes specific wrapper test projects on Browser and excludes call.cs via Condition.
src/tests/JIT/Directed/tailcall/mutual_recursion.fs Adds Browser-only ActiveIssue to disable a known failing tailcall test on Browser.
src/tests/CoreMangLib/system/span/RefStructWithSpan.cs Gates a multithreaded stress test on multithreading support via ConditionalFact.
src/tests/CoreMangLib/CoreMangLib.csproj Adds TestLibrary project reference to support new PlatformDetection usage.

Comment thread eng/pipelines/coreclr/ci.yml Outdated
@radekdoulik
Copy link
Copy Markdown
Member Author

@akoeplinger @jkoritzinsky how can I test the changes in ci.yml?

@jkoritzinsky
Copy link
Copy Markdown
Member

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copilot AI review requested due to automatic review settings April 27, 2026 11:05
@radekdoulik
Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts CoreCLR WASM outerloop coverage by enabling browser_wasm Priority1 runtime test execution while suppressing known-failing tests (mainly browser/interpreter and single-threaded WASM constraints).

Changes:

  • Enable CoreCLR outerloop runs for browser_wasm in the CoreCLR CI pipeline (build + test run jobs).
  • Guard multithreaded tests with IsMultithreadingSupported and add needed TestLibrary project references.
  • Exclude/skip known failing tests on Browser/WASM via ActiveIssue and csproj conditional excludes.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/tests/Loader/classloader/MethodImpl/Desktop/self_override5.il Adds ActiveIssue skip on Browser for a known failure.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_xor.cs Switches to ConditionalFact gated on multithreading support.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_sub.cs Switches to ConditionalFact gated on multithreading support.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_shr.cs Switches to ConditionalFact gated on multithreading support.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_or.cs Switches to ConditionalFact gated on multithreading support.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_mul.cs Switches to ConditionalFact gated on multithreading support.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_mod.cs Switches to ConditionalFact gated on multithreading support.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_div.cs Switches to ConditionalFact gated on multithreading support.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_and.cs Switches to ConditionalFact gated on multithreading support.
src/tests/JIT/jit64/opt/cse/VolatileTest_op_add.cs Switches to ConditionalFact gated on multithreading support.
src/tests/JIT/jit64/opt/cse/VolatileTest.csproj Adds TestLibrary reference to support PlatformDetection usage.
src/tests/JIT/Methodical/Methodical_ro.csproj Excludes a known failing source file on browser builds.
src/tests/JIT/Methodical/Methodical_r2.csproj Excludes known failing browser/interpreter projects and source file.
src/tests/JIT/Methodical/Methodical_do.csproj Excludes a known failing source file on browser builds.
src/tests/JIT/Methodical/Methodical_d2.csproj Excludes known failing browser/interpreter projects and source file.
src/tests/JIT/Directed/tailcall/mutual_recursion.fs Adds ActiveIssue skip on Browser.
src/tests/CoreMangLib/system/span/RefStructWithSpan.cs Switches to ConditionalFact gated on multithreading support.
src/tests/CoreMangLib/CoreMangLib.csproj Adds TestLibrary reference to support PlatformDetection usage.
eng/pipelines/coreclr/ci.yml Adds checked browser_wasm build + outerloop test run jobs.
eng/liveBuilds.targets Ensures Browser CoreCLR live-build runtime file set includes browser host artifacts when present.

Comment thread eng/pipelines/coreclr/ci.yml
@radekdoulik
Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants