Haiku: Remove redundant PIC/PIE flags#127443
Closed
trungnt2910 wants to merge 1 commit intodotnet:mainfrom
Closed
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts native build/link flags for Haiku to avoid passing redundant or conflicting PIC/PIE options.
Changes:
- Excludes Haiku targets from adding
-pieto executable linker flags. - Removes explicit executable compile options (
-fPIE/ Haiku-specific-fPIC) from this platform-flag block.
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-config
branch
from
fae43c7 to
e8380f2
Compare
Haiku toolchains already pass `-pic` and link everything as shared objects (`-shared`). `-pic` is therefore redundant. `-pie` may also cause additional problems when passed to the linker along with `-shared`.
trungnt2910
force-pushed
the
dev/trungnt2910/haiku-config
branch
from
e8380f2 to
5a9184f
Compare
Contributor
Author
|
Closing, this messes up native builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haiku toolchains already pass
-picand link everything as shared objects (-shared).-picis therefore redundant.-piemay also cause additional problems when passed to the linker along with-shared.Part of #55803.