Skip to content

Handle missing Network.framework peer certificate chain #127451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liveans merged 1 commit into from
Apr 27, 2026
+13 −2
Merged

Handle missing Network.framework peer certificate chain #127451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/libraries/System.Net.Security/src/System/Net/CertificateValidationPal.OSX.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,24 @@ internal static SslPolicyErrors VerifyCertificateProperties(

X509Certificate2? result = null;

SafeX509ChainHandle chainHandle = securityContext switch
SafeX509ChainHandle? chainHandle = securityContext switch
{
SafeDeleteNwContext nwContext => nwContext.PeerX509ChainHandle!,
SafeDeleteNwContext nwContext => nwContext.PeerX509ChainHandle,
SafeDeleteSslContext sslContext => Interop.AppleCrypto.SslCopyCertChain(sslContext.SslContext),
_ => throw new ArgumentException("Invalid context type", nameof(securityContext))
};

if (chainHandle is null || chainHandle.IsInvalid)
{
if (securityContext is SafeDeleteSslContext)
Comment thread
liveans marked this conversation as resolved.
{
chainHandle?.Dispose();
}

if (NetEventSource.Log.IsEnabled()) NetEventSource.Log.RemoteCertificate(result);
return result;
}

try
{
long chainSize = Interop.AppleCrypto.X509ChainGetChainSize(chainHandle);
Expand Down
Loading