Skip to content

Fix TensorPrimitives.IndexOfMax #127454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lilinus wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix TensorPrimitives.IndexOfMax #127454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b76b08
Fix and refactor IndexOfMinMaxCore
lilinus Apr 27, 2026
2bf8dee
Add test cases
lilinus Apr 27, 2026
97a1aea
Minor fix
lilinus Apr 27, 2026
2304dc9
FB
lilinus Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
761 changes: 679 additions & 82 deletions ...s.Tensors/src/System/Numerics/Tensors/netcore/Common/TensorPrimitives.IIndexOfOperator.cs
View file
Open in desktop

Large diffs are not rendered by default.

410 changes: 36 additions & 374 deletions ...ystem.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.IndexOfMax.cs
View file
Open in desktop

Large diffs are not rendered by default.

127 changes: 47 additions & 80 deletions ...erics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.IndexOfMaxMagnitude.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,111 +26,78 @@ public static int IndexOfMaxMagnitude<T>(ReadOnlySpan<T> x)
where T : INumber<T> =>
IndexOfMinMaxCore<T, IndexOfMaxMagnitudeOperator<T>>(x);

internal readonly struct IndexOfMaxMagnitudeOperator<T> : IIndexOfOperator<T> where T : INumber<T>
internal readonly struct IndexOfMaxMagnitudeOperator<T> : IIndexOfMinMaxOperator<T> where T : INumber<T>
{
public static T Aggregate(Vector128<T> x) => HorizontalAggregate<T, MaxMagnitudeOperator<T>>(x);
public static T Aggregate(Vector256<T> x) => HorizontalAggregate<T, MaxMagnitudeOperator<T>>(x);
public static T Aggregate(Vector512<T> x) => HorizontalAggregate<T, MaxMagnitudeOperator<T>>(x);

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Invoke(ref Vector128<T> result, Vector128<T> current, ref Vector128<T> resultIndex, Vector128<T> currentIndex)
{
Vector128<T> resultMag = Vector128.Abs(result), currentMag = Vector128.Abs(current);
Vector128<T> useResult = Vector128.GreaterThan(resultMag, currentMag);
Vector128<T> equalMask = Vector128.Equals(resultMag, currentMag);
public static bool IsQuickReturn(T value) => T.IsNaN(value);
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static Vector128<T> IsQuickReturn(Vector128<T> value) => IsNaN(value);
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static Vector256<T> IsQuickReturn(Vector256<T> value) => IsNaN(value);
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static Vector512<T> IsQuickReturn(Vector512<T> value) => IsNaN(value);

if (equalMask != Vector128<T>.Zero)
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static bool Compare(T x, T y)
{
T xMag = T.Abs(x), yMag = T.Abs(y);
if (xMag == yMag)
{
Vector128<T> lessThanIndexMask = IndexLessThan(resultIndex, currentIndex);
if (typeof(T) == typeof(float) || typeof(T) == typeof(double))
{
// bool useResult = equal && ((IsNegative(result) == IsNegative(current)) ? (resultIndex < currentIndex) : IsNegative(current));
Vector128<T> currentNegative = IsNegative(current);
Vector128<T> sameSign = Vector128.Equals(IsNegative(result).AsInt32(), currentNegative.AsInt32()).As<int, T>();
useResult |= equalMask & ElementWiseSelect(sameSign, lessThanIndexMask, currentNegative);
}
else
{
useResult |= equalMask & lessThanIndexMask;
}
return T.IsPositive(x) && T.IsNegative(y);
}
else
{
return xMag > yMag;
}

result = ElementWiseSelect(useResult, result, current);
resultIndex = ElementWiseSelect(useResult, resultIndex, currentIndex);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Invoke(ref Vector256<T> result, Vector256<T> current, ref Vector256<T> resultIndex, Vector256<T> currentIndex)
public static Vector128<T> Compare(Vector128<T> x, Vector128<T> y)
{
Vector256<T> resultMag = Vector256.Abs(result), currentMag = Vector256.Abs(current);
Vector256<T> useResult = Vector256.GreaterThan(resultMag, currentMag);
Vector256<T> equalMask = Vector256.Equals(resultMag, currentMag);

if (equalMask != Vector256<T>.Zero)
Vector128<T> xMag = Vector128.Abs(x), yMag = Vector128.Abs(y);
if (typeof(T) == typeof(double) || typeof(T) == typeof(float))
{
Vector256<T> lessThanIndexMask = IndexLessThan(resultIndex, currentIndex);
if (typeof(T) == typeof(float) || typeof(T) == typeof(double))
{
// bool useResult = equal && ((IsNegative(result) == IsNegative(current)) ? (resultIndex < currentIndex) : IsNegative(current));
Vector256<T> currentNegative = IsNegative(current);
Vector256<T> sameSign = Vector256.Equals(IsNegative(result).AsInt32(), currentNegative.AsInt32()).As<int, T>();
useResult |= equalMask & ElementWiseSelect(sameSign, lessThanIndexMask, currentNegative);
}
else
{
useResult |= equalMask & lessThanIndexMask;
}
Vector128<T> equalResult = IsPositive(x) & IsNegative(y);
return Vector128.GreaterThan(xMag, yMag) | (Vector128.Equals(xMag, yMag) & equalResult);
}
else
{
return Vector128.GreaterThan(xMag, yMag);
}

result = ElementWiseSelect(useResult, result, current);
resultIndex = ElementWiseSelect(useResult, resultIndex, currentIndex);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Invoke(ref Vector512<T> result, Vector512<T> current, ref Vector512<T> resultIndex, Vector512<T> currentIndex)
public static Vector256<T> Compare(Vector256<T> x, Vector256<T> y)
{
Vector512<T> resultMag = Vector512.Abs(result), currentMag = Vector512.Abs(current);
Vector512<T> useResult = Vector512.GreaterThan(resultMag, currentMag);
Vector512<T> equalMask = Vector512.Equals(resultMag, currentMag);

if (equalMask != Vector512<T>.Zero)
Vector256<T> xMag = Vector256.Abs(x), yMag = Vector256.Abs(y);
if (typeof(T) == typeof(double) || typeof(T) == typeof(float))
{
Vector512<T> lessThanIndexMask = IndexLessThan(resultIndex, currentIndex);
if (typeof(T) == typeof(float) || typeof(T) == typeof(double))
{
// bool useResult = equal && ((IsNegative(result) == IsNegative(current)) ? (resultIndex < currentIndex) : IsNegative(current));
Vector512<T> currentNegative = IsNegative(current);
Vector512<T> sameSign = Vector512.Equals(IsNegative(result).AsInt32(), currentNegative.AsInt32()).As<int, T>();
useResult |= equalMask & ElementWiseSelect(sameSign, lessThanIndexMask, currentNegative);
}
else
{
useResult |= equalMask & lessThanIndexMask;
}
Vector256<T> equalResult = IsPositive(x) & IsNegative(y);
return Vector256.GreaterThan(xMag, yMag) | (Vector256.Equals(xMag, yMag) & equalResult);
}
else
{
return Vector256.GreaterThan(xMag, yMag);
}

result = ElementWiseSelect(useResult, result, current);
resultIndex = ElementWiseSelect(useResult, resultIndex, currentIndex);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static int Invoke(ref T result, T current, int resultIndex, int currentIndex)
public static Vector512<T> Compare(Vector512<T> x, Vector512<T> y)
{
T resultMag = T.Abs(result);
T currentMag = T.Abs(current);

if (resultMag == currentMag)
Vector512<T> xMag = Vector512.Abs(x), yMag = Vector512.Abs(y);
if (typeof(T) == typeof(double) || typeof(T) == typeof(float))
{
bool resultNegative = IsNegative(result);
if ((resultNegative == IsNegative(current)) ? (currentIndex < resultIndex) : resultNegative)
{
result = current;
return currentIndex;
}
Vector512<T> equalResult = IsPositive(x) & IsNegative(y);
return Vector512.GreaterThan(xMag, yMag) | (Vector512.Equals(xMag, yMag) & equalResult);
}
else if (currentMag > resultMag)
else
{
result = current;
return currentIndex;
return Vector512.GreaterThan(xMag, yMag);
}

return resultIndex;
}
}
}
Expand Down
117 changes: 43 additions & 74 deletions ...ystem.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.IndexOfMin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,105 +26,74 @@ public static int IndexOfMin<T>(ReadOnlySpan<T> x)
IndexOfMinMaxCore<T, IndexOfMinOperator<T>>(x);

/// <summary>Returns the index of MathF.Min(x, y)</summary>
internal readonly struct IndexOfMinOperator<T> : IIndexOfOperator<T> where T : INumber<T>
internal readonly struct IndexOfMinOperator<T> : IIndexOfMinMaxOperator<T> where T : INumber<T>
{
public static T Aggregate(Vector128<T> x) => HorizontalAggregate<T, MinOperator<T>>(x);
public static T Aggregate(Vector256<T> x) => HorizontalAggregate<T, MinOperator<T>>(x);
public static T Aggregate(Vector512<T> x) => HorizontalAggregate<T, MinOperator<T>>(x);

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Invoke(ref Vector128<T> result, Vector128<T> current, ref Vector128<T> resultIndex, Vector128<T> currentIndex)
{
Vector128<T> useResult = Vector128.LessThan(result, current);
Vector128<T> equalMask = Vector128.Equals(result, current);
public static bool IsQuickReturn(T value) => T.IsNaN(value);
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static Vector128<T> IsQuickReturn(Vector128<T> value) => IsNaN(value);
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static Vector256<T> IsQuickReturn(Vector256<T> value) => IsNaN(value);
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static Vector512<T> IsQuickReturn(Vector512<T> value) => IsNaN(value);

if (equalMask != Vector128<T>.Zero)
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static bool Compare(T x, T y)
{
if (x == y)
{
Vector128<T> lessThanIndexMask = IndexLessThan(resultIndex, currentIndex);
if (typeof(T) == typeof(float) || typeof(T) == typeof(double))
{
// bool useResult = equal && ((IsNegative(result) == IsNegative(current)) ? (resultIndex < currentIndex) : IsNegative(result));
Vector128<T> resultNegative = IsNegative(result);
Vector128<T> sameSign = Vector128.Equals(resultNegative.AsInt32(), IsNegative(current).AsInt32()).As<int, T>();
useResult |= equalMask & ElementWiseSelect(sameSign, lessThanIndexMask, resultNegative);
}
else
{
useResult |= equalMask & lessThanIndexMask;
}
return T.IsNegative(x) && T.IsPositive(y);
}
else
{
return x < y;
}

result = ElementWiseSelect(useResult, result, current);
resultIndex = ElementWiseSelect(useResult, resultIndex, currentIndex);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Invoke(ref Vector256<T> result, Vector256<T> current, ref Vector256<T> resultIndex, Vector256<T> currentIndex)
public static Vector128<T> Compare(Vector128<T> x, Vector128<T> y)
{
Vector256<T> useResult = Vector256.LessThan(result, current);
Vector256<T> equalMask = Vector256.Equals(result, current);

if (equalMask != Vector256<T>.Zero)
if (typeof(T) == typeof(double) || typeof(T) == typeof(float))
{
Vector256<T> lessThanIndexMask = IndexLessThan(resultIndex, currentIndex);
if (typeof(T) == typeof(float) || typeof(T) == typeof(double))
{
// bool useResult = equal && ((IsNegative(result) == IsNegative(current)) ? (resultIndex < currentIndex) : IsNegative(result));
Vector256<T> resultNegative = IsNegative(result);
Vector256<T> sameSign = Vector256.Equals(resultNegative.AsInt32(), IsNegative(current).AsInt32()).As<int, T>();
useResult |= equalMask & ElementWiseSelect(sameSign, lessThanIndexMask, resultNegative);
}
else
{
useResult |= equalMask & lessThanIndexMask;
}
Vector128<T> equalResult = IsNegative(x) & IsPositive(y);
return Vector128.LessThan(x, y) | (Vector128.Equals(x, y) & equalResult);
}
else
{
return Vector128.LessThan(x, y);
}

result = ElementWiseSelect(useResult, result, current);
resultIndex = ElementWiseSelect(useResult, resultIndex, currentIndex);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Invoke(ref Vector512<T> result, Vector512<T> current, ref Vector512<T> resultIndex, Vector512<T> currentIndex)
public static Vector256<T> Compare(Vector256<T> x, Vector256<T> y)
{
Vector512<T> useResult = Vector512.LessThan(result, current);
Vector512<T> equalMask = Vector512.Equals(result, current);

if (equalMask != Vector512<T>.Zero)
if (typeof(T) == typeof(double) || typeof(T) == typeof(float))
{
Vector512<T> lessThanIndexMask = IndexLessThan(resultIndex, currentIndex);
if (typeof(T) == typeof(float) || typeof(T) == typeof(double))
{
// bool useResult = equal && ((IsNegative(result) == IsNegative(current)) ? (resultIndex < currentIndex) : IsNegative(result));
Vector512<T> resultNegative = IsNegative(result);
Vector512<T> sameSign = Vector512.Equals(resultNegative.AsInt32(), IsNegative(current).AsInt32()).As<int, T>();
useResult |= equalMask & ElementWiseSelect(sameSign, lessThanIndexMask, resultNegative);
}
else
{
useResult |= equalMask & lessThanIndexMask;
}
Vector256<T> equalResult = IsNegative(x) & IsPositive(y);
return Vector256.LessThan(x, y) | (Vector256.Equals(x, y) & equalResult);
}
else
{
return Vector256.LessThan(x, y);
}

result = ElementWiseSelect(useResult, result, current);
resultIndex = ElementWiseSelect(useResult, resultIndex, currentIndex);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static int Invoke(ref T result, T current, int resultIndex, int currentIndex)
public static Vector512<T> Compare(Vector512<T> x, Vector512<T> y)
{
if (result == current)
if (typeof(T) == typeof(double) || typeof(T) == typeof(float))
{
bool currentNegative = IsNegative(current);
if ((IsNegative(result) == currentNegative) ? (currentIndex < resultIndex) : currentNegative)
{
result = current;
return currentIndex;
}
Vector512<T> equalResult = IsNegative(x) & IsPositive(y);
return Vector512.LessThan(x, y) | (Vector512.Equals(x, y) & equalResult);
}
else if (current < result)
else
{
result = current;
return currentIndex;
return Vector512.LessThan(x, y);
}

return resultIndex;
}
}
}
Expand Down
Loading
Loading