Skip to content

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962801#127475

Open
dotnet-bot wants to merge 1 commit intomainfrom
locfiles/15ae61be-cc84-4b80-bf6c-ae4d17af3027
Open

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962801#127475
dotnet-bot wants to merge 1 commit intomainfrom
locfiles/15ae61be-cc84-4b80-bf6c-ae4d17af3027

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Copilot Code Review — PR #127475

Holistic Assessment

Motivation: This is an automated localization check-in by OneLocBuild (Build ID 2961630), providing actual translations for 4 previously untranslated strings in the System.Text.Json source generator's .xlf resource files. The strings had state="new" (English source text used as placeholder targets) and needed proper translations — this is routine and justified.

Approach: Standard OneLocBuild workflow — replaces English placeholder targets with actual localized translations across all 13 supported languages and updates the state attribute from "new" to "translated". This is the expected process for localization in dotnet/runtime.

Summary: ✅ LGTM. Mechanical localization update with zero code or behavioral changes. All format string placeholders ({0}, {1}) are correctly preserved in all 52 translated strings. The change is perfectly balanced (52 insertions, 52 deletions = 4 strings × 13 languages).


Detailed Findings

✅ Translation Completeness — All 4 strings translated consistently across all 13 languages

The same 4 trans-units are updated in every .xlf file (cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant):

  • InaccessibleJsonIncludePropertiesNotSupportedFormat (format string with {0}.{1})
  • InaccessibleJsonIncludePropertiesNotSupportedTitle
  • JsonIgnoreConditionAlwaysInvalidOnTypeFormat (format string with {0})
  • JsonIgnoreConditionAlwaysInvalidOnTypeTitle

Each file changes exactly 8 lines (4 removed, 4 added). No language is missing updates.

✅ Format Placeholder Integrity — All placeholders preserved

Verified that {0} and {1} format placeholders are correctly retained in all translations that require them:

  • All 13 InaccessibleJsonIncludePropertiesNotSupportedFormat translations contain both {0} and {1}
  • All 13 JsonIgnoreConditionAlwaysInvalidOnTypeFormat translations contain {0}
  • The two Title strings have no placeholders (matching the source) ✓

✅ State Attribute Correctness — Proper XLF lifecycle transitions

All entries correctly transition from state="new" to state="translated", which is the standard XLIFF lifecycle for completed translations.

✅ No Code or API Changes — Localization-only PR

No .cs, .csproj, ref assembly, or other source files are modified. No new public API surface detected. This PR has zero risk of behavioral regression.

Generated by Code Review for issue #127475 ·

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961630 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961672 Apr 27, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961672 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961810 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961810 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961891 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961891 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961956 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2961956 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962100 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962100 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962111 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962111 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962182 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962182 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962232 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962232 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962252 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962252 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962272 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962272 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962358 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962358 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962412 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962412 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962446 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962446 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962487 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962487 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962527 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962527 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962610 Apr 28, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962610 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2962801 Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant