Re-enable Concurrent and Text.Json tests on CoreCLR Apple mobile

[Copilot]

Description

System.Collections.Concurrent.Tests and System.Text.Json.Tests were excluded across all CoreCLR Apple mobile targets.

[dotnet-policy-service]

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

[kotlarmilos]

/azp run runtime-ioslike

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Copilot]

Pull request overview

This PR re-enables System.Collections.Concurrent.Tests and System.Text.Json.Tests for CoreCLR Apple mobile test runs by removing their project-level exclusions, while adding a targeted [ActiveIssue] skip for a known-failing ConcurrentDictionary test on CoreCLR Apple mobile.

Changes:

• Removed CoreCLR Apple mobile exclusions for System.Collections.Concurrent.Tests and System.Text.Json.Tests from src/libraries/tests.proj.
• Added an [ActiveIssue] annotation to skip a specific ConcurrentDictionary theory on IsAppleMobile && IsCoreCLR.

Show a summary per file

File	Description
src/libraries/tests.proj	Stops excluding Concurrent and Text.Json test projects for CoreCLR Apple mobile targets, allowing them to run again.
src/libraries/System.Collections.Concurrent/tests/ConcurrentDictionary/ConcurrentDictionary.Generic.Tests.cs	Adds a targeted active-issue skip for a specific failing test on CoreCLR Apple mobile.

Copilot's findings

• Files reviewed: 2/2 changed files
• Comments generated: 0

[github-actions]

🤖 Copilot Code Review — PR #127497

Note

This review was generated by GitHub Copilot.

Holistic Assessment

Motivation: The PR narrows overly broad test exclusions for Apple mobile CoreCLR runs. Previously, entire test projects (System.Collections.Concurrent.Tests, System.Text.Json.Tests) were excluded due to timeout issues. This is a clear improvement — blanket project exclusions hide many passing tests and reduce CI signal.

Approach: The approach is correct and follows established patterns in the repository. The [ActiveIssue] attribute with multi-property platform conditions (IsAppleMobile + IsCoreCLR) is the standard mechanism for skipping individual tests on specific platforms, and System.Text.Json.Tests is fully re-enabled. The System.Net.HttpListener.Tests exclusion is retained for ongoing timeout issues.

Summary: ✅ LGTM. Small, focused CI-infrastructure change that improves test coverage on Apple mobile platforms by replacing blanket project exclusions with targeted test-level skip attributes. The ActiveIssue usage is syntactically correct and follows existing patterns in the same test directory.

---

Detailed Findings

✅ ActiveIssue attribute usage — Correct pattern

The [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] attribute follows the established multi-property overload pattern used elsewhere in the repo (e.g., ConcurrentQueueTests.cs:215 uses the same pattern with IsBrowser + IsCoreCLR). The AND semantics correctly target only Apple mobile + CoreCLR configurations.

✅ Test exclusion narrowing — Good practice

Removing the blanket System.Collections.Concurrent.Tests.csproj exclusion and replacing it with a per-test [ActiveIssue] on only NonRandomizedToRandomizedUpgrade_FunctionsCorrectly is the right granularity. This unblocks all other tests in the project on Apple mobile.

✅ System.Text.Json.Tests re-enabled

Removing the System.Text.Json.Tests exclusion entirely indicates these tests are now passing on Apple mobile CoreCLR. This increases test coverage.

💡 HttpListener exclusion lacks a tracking issue

The <!-- Timeouts --> comment for the System.Net.HttpListener.Tests.csproj exclusion does not reference a specific GitHub issue. Other exclusions in the same ItemGroup reference https://github.com/dotnet/runtime/issues/124344. Consider filing a tracking issue and updating the comment to follow the same pattern, so the exclusion can be tracked and eventually resolved. This is a follow-up item, not a blocker.

Generated by Code Review for issue #127497 · ◷

[kotlarmilos]

/azp run runtime-ioslike

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).