JIT: Add canonicalization to GT_EQ and GT_NE#127548
Open
BoyBaykiller wants to merge 3 commits intodotnet:mainfrom
Open
JIT: Add canonicalization to GT_EQ and GT_NE#127548BoyBaykiller wants to merge 3 commits intodotnet:mainfrom
GT_EQ and GT_NE#127548BoyBaykiller wants to merge 3 commits intodotnet:mainfrom
Conversation
* also canonicalize '(A & pow2) == pow2' to '(A & pow2) != 0'
github-actions
Bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
BoyBaykiller
commented
Apr 29, 2026
| } | ||
|
|
||
| // Canonicalize '(A & pow2) == pow2' -> '(A & pow2) != 0' | ||
| if (cmp->OperIs(GT_EQ) && op1->OperIs(GT_AND) && op1->gtGetOp2()->IsIntegralConstUnsignedPow2()) |
Contributor
Author
There was a problem hiding this comment.
The IsIntegralConstUnsignedPow2 check misses 1 << 31 (or 1 << 63). I need to know if there is only a single bit set. Naturally I would do Popcount(x) == 1, but how can I get the unsigned/not-sign-extend literal? All the APIs seem to sign extend first.
This was referenced Apr 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SELECT(x & 16 == 16, y | 16, y) -> y | (x & 16)