Skip to content

Annotate System.Security.Claims for nullable#1431

Merged
buyaa-n merged 6 commits into
dotnet:masterfrom
buyaa-n:security-claims
Jan 12, 2020
Merged

Annotate System.Security.Claims for nullable#1431
buyaa-n merged 6 commits into
dotnet:masterfrom
buyaa-n:security-claims

Conversation

@buyaa-n
Copy link
Copy Markdown
Contributor

@buyaa-n buyaa-n commented Jan 8, 2020

Copy link
Copy Markdown
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@buyaa-n buyaa-n requested a review from bartonjs January 8, 2020 23:23
Comment thread src/libraries/System.Security.Claims/src/System/Security/Claims/Claim.cs Outdated
Comment thread src/libraries/System.Security.Claims/src/System/Security/Claims/ClaimsIdentity.cs Outdated
Comment thread src/libraries/System.Security.Claims/src/System/Security/Claims/ClaimsIdentity.cs Outdated
Copy link
Copy Markdown
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments/questions to be addressed, but otherwise LGTM.

@buyaa-n buyaa-n merged commit 130e184 into dotnet:master Jan 12, 2020
@buyaa-n buyaa-n deleted the security-claims branch February 13, 2020 01:35
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
@dotnet-policy-service dotnet-policy-service Bot added the in-pr There is an active PR which will close this issue when it is merged label Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Security in-pr There is an active PR which will close this issue when it is merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants