Add RunSample target to mono.proj #2393
Conversation
|
@EgorBo Can we add makefile targets in order to make it easier for some of us to use? |
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
Good start but we should move more of the logic into msbuild :)
| SkipUnchangedFiles="true"/> | ||
| </Target> | ||
|
|
||
| <!-- Run netcore\sample\HelloWorld sample using Mono Runtime --> |
There was a problem hiding this comment.
I am not sure it's worth it. I'd prefer to have better documentation for this instead
There was a problem hiding this comment.
@marek-safar um.. what exactly is not worth it? -- having the RunSample target?
There was a problem hiding this comment.
yeah, I'd much rather see documentation with working steps for dotnet new .... to run on MonoVM
There was a problem hiding this comment.
Wouldn't this have temporary value until we figure that part out? I know some people like to use RunSample as an easy way to test their stuff.
There was a problem hiding this comment.
I guess we figure it out already if we can run the sample which is form of dotnet new console
There was a problem hiding this comment.
I see what you mean. Yeah, I agree.
There was a problem hiding this comment.
it seems most of us use HelloWorld for experiments/fixes/improvements. Do you suggest to remove it and let everybody do:
dotnet new console
dotnet publish -c Release -r osx-x64
copy libcoreclr.dylib & SPC.dll by hands to the publish directory
instead of make run-sample ?
Currently run-sample doesn't require patching local .dotnet (which imo should be avoided if possible). Also there is a rule make run-sample-coreclr which does use local .dotnet (useful to compare results between both runtimes)
There was a problem hiding this comment.
yep, I think having this document something is more valuable than having it in Makefile (although you can keep sample of this example if you think it's valuable)
There was a problem hiding this comment.
I've simplified all the things so now runsample uses local dotnet. But I personally would prefer to keep it at least for a while.
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
looks almost perfect, just needs a few little fixes :)
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
missing parenthesis but looks good otherwise
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-Authored-By: Alexander Köplinger <alex.koeplinger@outlook.com>
|
Sorry, forgot to squash it 😢 (it used to be a default behavior in mono/mono) |
ghost
locked as resolved and limited conversation to collaborators
5 participants
src/mono/netcore/corerun/folder, we can build/use coreclr's corerun (it has--clr-path)RunSampleto build & run HelloWorld with mono runtime.