Update SkipOnCoreClrAttributes to new parameters#28875
Conversation
| namespace System.ComponentModel.Composition.Registration.Tests | ||
| { | ||
| [SkipOnCoreClr("Test failures on stress tests")] | ||
| [SkipOnCoreClr("Test failures on stress tests", RuntimeTestModes.CheckedRuntime)] |
There was a problem hiding this comment.
Is it just checked builds, or any of the stress / non-release configurations?
There was a problem hiding this comment.
This would apply to ALL Checked builds, no matter if it is stress or not.
However, I just realized that the current design is not great as if we added a | RuntimeTestModes.GCStress it would mean, ALL Checked or GCStress (Checked or Release), as I would think what we want is that if I say RuntimeTestModes.Checked it would mean, ALL Checked, but if I add an stress mode flag, then it would mean, ONLY skip when running GCStress when in Checked. What is your expectation/thought for that?
There was a problem hiding this comment.
@stephentoub thoughts on that?
I'll include this change in the arcade update to unblock and can update again based on your thoughts. I think updating it to the latter is the ideal.
There was a problem hiding this comment.
Actually, I gave it a thought and put up a PR to update it to a better way of doing it: dotnet/arcade#4764
|
|
||
| [assembly: SkipOnCoreClr("System.Net.Tests are flaky and/or long running: https://github.com/dotnet/runtime/issues/131")] | ||
| [assembly: SkipOnCoreClr("System.Net.Tests are flaky and/or long running: https://github.com/dotnet/runtime/issues/131", RuntimeTestModes.CheckedRuntime)] | ||
| [assembly: SkipOnMono("System.Net.Tests are flaky and/or long running: https://github.com/dotnet/runtime/issues/131")] |
There was a problem hiding this comment.
Do we know if mono actually had problems with these or just copied the coreclr attribution thinking it was about all configs and not just stress?
There was a problem hiding this comment.
My assumption here is that mono did have problems with this, and ActiveIssue isn't usable on an assembly level. @akoeplinger ?
There was a problem hiding this comment.
I think I just copied from CoreCLR so this might not be needed.
|
Closing as I included this change in: #19613 |
ghost
locked as resolved and limited conversation to collaborators
4 participants
Depends on: dotnet/arcade#4724 change to flow via arcade.