Remove --buildXUnitWrappers from runtest.cmd/runtest.sh#31798
Merged
jashook merged 1 commit intodotnet:masterfrom Feb 25, 2020
Merged
Remove --buildXUnitWrappers from runtest.cmd/runtest.sh#31798jashook merged 1 commit intodotnet:masterfrom
jashook merged 1 commit intodotnet:masterfrom
Conversation
jashook
approved these changes
Feb 25, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks unused, it forwards
--build_xunit_test_wrapperstoruntests.pywhich is not handled there (see https://github.com/dotnet/runtime/blob/master/src/coreclr/tests/runtest.py)so
buildxunitwrapperspassed to build.sh/cmd simply fails withunknown parameter --build_xunit_test_wrappersin the python script.