Skip to content

Fix AppDomain.SetPrincipalPolicy bug for new threads#32104

Merged
jkotas merged 3 commits into
dotnet:masterfrom
MarcoRossignoli:fixwindowsprincipalpolicy
Feb 12, 2020
Merged

Fix AppDomain.SetPrincipalPolicy bug for new threads#32104
jkotas merged 3 commits into
dotnet:masterfrom
MarcoRossignoli:fixwindowsprincipalpolicy

Conversation

@MarcoRossignoli
Copy link
Copy Markdown
Member

Fixes #31717

Old code did

return CurrentThread._principal ?? (CurrentThread._principal = AppDomain.CurrentDomain.GetThreadPrincipal());

I missed to bring principal null check 😡

cc: @jkotas @stephentoub

PS. Debug cross repo is great(lib->coreclr), but it's a bit slow due to debug build of EE, is there a way to build EE in release and only managed part(System.Private.CoreLib) in debug?

@MarcoRossignoli
Copy link
Copy Markdown
Member Author

@MarcoRossignoli
Copy link
Copy Markdown
Member Author

/azp list

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 32104 in repo dotnet/runtime

Comment thread src/libraries/System.Private.CoreLib/src/System/Threading/Thread.cs Outdated
@jkotas
Copy link
Copy Markdown
Member

jkotas commented Feb 11, 2020

The CI error is known problem. All PRs are hitting it.

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Feb 11, 2020

is there a way to build EE in release and only managed part

https://github.com/dotnet/runtime/blob/master/docs/workflow/building/libraries/README.md

@MarcoRossignoli
Copy link
Copy Markdown
Member Author

MarcoRossignoli commented Feb 11, 2020

https://github.com/dotnet/runtime/blob/master/docs/workflow/building/libraries/README.md

Not sure there is what I would...for clr cannot build EE in release and c# in debug I can only specify one -c, btw no probs

Copy link
Copy Markdown
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Feb 12, 2020

The test failures are known issue #32126

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AppDomain.SetPrincipalPolicy(PrincipalPolicy.WindowsPrincipal) works only once

3 participants