Fix AppDomain.SetPrincipalPolicy bug for new threads#32104
Merged
Conversation
Member
Author
|
Got this error from CI https://helix.dot.net/api/2019-06-17/jobs/c7ca5c04-d00f-417f-9b34-3e48d889129d/workitems/System.Threading.Tasks.Tests/console but seem unrelated to my update. |
Member
Author
|
/azp list |
|
Commenter does not have sufficient privileges for PR 32104 in repo dotnet/runtime |
jkotas
reviewed
Feb 11, 2020
Member
|
The CI error is known problem. All PRs are hitting it. |
Member
https://github.com/dotnet/runtime/blob/master/docs/workflow/building/libraries/README.md |
Member
Author
Not sure there is what I would...for clr cannot build EE in release and c# in debug I can only specify one -c, btw no probs |
Member
|
The test failures are known issue #32126 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31717
Old code did
I missed to bring principal null check 😡
cc: @jkotas @stephentoub
PS. Debug cross repo is great(lib->coreclr), but it's a bit slow due to debug build of EE, is there a way to build EE in release and only managed part(
System.Private.CoreLib) in debug?