Skip to content

Conversation

@stephentoub
Copy link
Member

Fixes #24694
Fixes #23819

@GrabYourPitchforks, are the Xor methods really necessary? Where do you expect them to be used?

cc: @jkotas, @GrabYourPitchforks, @tannergooding

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@GrabYourPitchforks
Copy link
Member

are the Xor methods really necessary? Where do you expect them to be used?

I see some unmanaged usage with regard to job scheduling, but the scenarios for this (at least in C#) don't seem as clear-cut as the scenarios for And and Or. I'm not going to be terribly sad if we decide to nix Xor. It was really just for logical operator completeness.

@stephentoub
Copy link
Member Author

I'm not going to be terribly sad if we decide to nix xor

Ok, I'm going to remove it. I want to add things only when there's a strong demonstrated need, and I'm not seeing that for xor.

@stephentoub stephentoub merged commit 4107a4c into dotnet:master Feb 14, 2020
@stephentoub stephentoub deleted the interlockedadds branch February 14, 2020 17:12
@MihaZupan MihaZupan mentioned this pull request Mar 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interlocked.CompareExchange missing for uint, ulong and (if possible) general structs. Add bit manipulation methods to Interlocked class

6 participants