-
Notifications
You must be signed in to change notification settings - Fork 5.4k
One shot pem reader and writer #32260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
8cc21eb
Find / TryFind PEM
vcsjones 508b09a
Implement GetEncodedSize.
vcsjones 0b628d0
Added writing and complete doc-comments.
vcsjones b9c418f
Avoid an allocation for sensible label sizes.
vcsjones fb4e77c
Stackalloc outside loop once.
vcsjones 7965127
Fix Windows line handling.
vcsjones 558a937
Code review feedback.
vcsjones 8d8c34b
Document value of PemFields.
vcsjones 69dfb80
Document exception for Write and TryWrite.
vcsjones 13beb43
whitespace => white space
vcsjones 4ee4b1c
Rewrite in terms without lines.
vcsjones 2362abf
Minor refactoring
vcsjones 2745dfa
Add test for mismatched labels
vcsjones 0c71711
Fix label validation.
vcsjones 8107961
Validate label when writing.
vcsjones 9a84a4d
Use clearer increment.
vcsjones 3985611
Documentation feedback.
vcsjones 5c9ebd3
Formatting cleanup.
vcsjones 8ceff01
Remove line handling tests.
vcsjones 43ed5b5
Some test refactoring.
vcsjones a991f1e
WIP
vcsjones 7dbbfde
Merge remote-tracking branch 'ms/master' into one-shot-pem
vcsjones 422a8ed
Fix tests and base64 location
vcsjones 3a222ee
Use an offset helper to reduce IndexOf gymnastics.
vcsjones 919ba8a
Rename
vcsjones 348f997
Re-organize tests.
vcsjones 11ad108
Formatting
vcsjones 3150dd5
Fixup decoding size calculation to not overflow an int
vcsjones 3f6738e
Additional code review feedback.
vcsjones bf18476
Remove duplicate tests.
vcsjones 16cf85a
Add additional tests for base64 padding.
vcsjones 0ede347
Additional tests.
vcsjones b78ef7e
Improve assert extensions.
vcsjones 430d2c6
Remove wrapping that is not required
vcsjones 159df24
Add comment explaining label composition.
vcsjones 7b9c08f
Brace for impact.
vcsjones 27e120c
Remove open-ended ranges and use Slice.
vcsjones f3538cc
Correct IsValidLabel.
vcsjones dff24c1
Test additions.
vcsjones 19f45b2
Fix test names
vcsjones 6735d32
More specific definition of white space.
vcsjones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.