Add skip reason to SkipOnMono attribute #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Nov 27, 2019
src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Nov 27, 2019
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Other than the actual message, LGTM.
stephentoub
approved these changes
Nov 27, 2019
Member
|
Thanks for the quick fix!
See #228 (comment) |
MichalStrehovsky
pushed a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Nov 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build failures introduced on: #228
I don't know why the PR builds were green.
cc: @stephentoub @EgorBo