Annotate System.Net.Security for nullable reference types#32541
Annotate System.Net.Security for nullable reference types#32541eiriktsarpalis merged 17 commits intodotnet:masterfrom
Conversation
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/CipherSuitesPolicy.cs
Outdated
Show resolved
Hide resolved
d496304 to
9c18638
Compare
|
Rebased on top of newly added System.Net.Primitives annotations |
Refers to: src/libraries/System.Net.Security/ref/System.Net.Security.cs:583 in cadecbf. [](commit_id = cadecbf680f43be03eb4fd7ca59df230ffe075ba, deletion_comment = False) |
From a quick look at the code, it appears that Refers to: src/libraries/System.Net.Security/ref/System.Net.Security.cs:617 in cadecbf. [](commit_id = cadecbf680f43be03eb4fd7ca59df230ffe075ba, deletion_comment = False) |
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Crypto.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.Ssl.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Windows/SspiCli/NegotiationInfoClass.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Windows/SspiCli/ISSPIInterface.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Windows/SspiCli/SSPIWrapper.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Net/Security/Unix/SafeFreeSslCredentials.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/SecureChannel.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/SslApplicationProtocol.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/TlsCipherSuiteData.cs
Outdated
Show resolved
Hide resolved
7b71436 to
7c2094f
Compare
7c2094f to
ed7856f
Compare
|
Rebased on top of System.Net.Sockets annotations. |
eerhardt
left a comment
There was a problem hiding this comment.
Assuming your questions to the library owners are resolved, this LGTM. Nice work.
Contributes to #2339
I think I might have spotted a few bugs, please see my comments in the diff /cc @dotnet/ncl