Use VS2019 Preview for libraries build which contains a newer CMake#32626
Merged
Conversation
MattGal
approved these changes
Feb 21, 2020
Member
MattGal
left a comment
MattGal
left a comment
There was a problem hiding this comment.
LGTM. I like the idea of leaving it around as a switch so you can turn it off and on. I almost wonder if you should add the switch to coreclr and start it as off?
Member
|
Thanks for getting us back to a good state, @safern (or, at least a better one). |
Member
Author
|
Perf job is failing. Need to take a look at what’s going on and I’ll update the PR before merging. |
This was referenced Feb 25, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #31888
This re-enable warnaserror on Windows as it was before.
The reason why I just updated it for Libraries is because coreclr was failing because of the newer Windows SDK when building the tests. It seems like the toolset changed so I’ll follow up with @MattGal and when I’m back update to use the same pool and toolset for the whole repo. Also because of that I can’t enable warnaserror in the live local CI build but we get enough coverage with the regular CI build with this change now.
cc: @dotnet/runtime-infrastructure @stephentoub