Update tests to deserialize char so that they align better with the behavior being tested. #32636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behavior being tested.
ahsonkhan
requested review from
jozkee,
layomia and
steveharter
as code owners
Contributor
Author
|
CI failure is unrelated: #32638 |
jozkee
approved these changes
Feb 21, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a couple of corrections that we should make to the tests that deserialize JSON into char.
We were testing empty JSON payload rather than a non-empty payload containing an empty JSON string. Similarly, the quotes on one of the case was misplaced (resulting in invalid JSON), which wasn't the intent of this test.
These tests were added in #528