Skip to content

Make Uri Thread-Safe #33042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 11 commits into from
May 9, 2020
Merged

Make Uri Thread-Safe #33042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6d08aad
Do not lock on string in Uri
MihaZupan Mar 2, 2020
5077075
Make Uri thread-safe without locks
MihaZupan Mar 3, 2020
129806f
Merge master
MihaZupan May 4, 2020
c78c5e9
Update comments
MihaZupan May 4, 2020
77b5c42
Use existing style for enum values
MihaZupan May 4, 2020
b4b821a
Add a comment about locking for custom parsers
MihaZupan May 4, 2020
a577aae
Add a comment about DebugSetLeftCtor usage
MihaZupan May 4, 2020
02aaf76
Add trailing dot in exception message
MihaZupan May 4, 2020
3721ffa
Fix typos
MihaZupan May 4, 2020
2af3a83
Merge master
MihaZupan May 5, 2020
aac8b57
Fix typo
MihaZupan May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/libraries/System.Private.Uri/src/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<root>
<?xml version="1.0" encoding="utf-8"?>
<root>
<!--
Microsoft ResX Schema

Expand Down Expand Up @@ -191,4 +192,7 @@
<data name="Arg_KeyNotFoundWithKey" xml:space="preserve">
<value>The given key '{0}' was not present in the dictionary.</value>
</data>
<data name="net_uri_InitializeCalledAlreadyOrTooLate" xml:space="preserve">
<value>UriParser's base InitializeAndValidate may only be called once on a single Uri instance and only from an override of InitializeAndValidate.</value>
</data>
</root>
Loading