Skip to content

Set GenFacadesForceZeroVersionSeeds for all shims #33052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Mar 3, 2020
Merged

Set GenFacadesForceZeroVersionSeeds for all shims #33052

1 commit merged into from
Mar 3, 2020

Conversation

@ericstj
Copy link
Member

@ericstj ericstj commented Mar 2, 2020

Opts into GenFacadesForceZeroVersionSeeds for all shims. This is consistent with what we did in 2.x.

I've manually updated GenFacades rather than wait for #32858

@ericstj ericstj requested review from Anipik and joperezr March 2, 2020 18:13
@ericstj ericstj self-assigned this Mar 2, 2020
Anipik
Anipik approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericstj are we porting this to 3.1 as well ?

joperezr
joperezr approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I'm sure you did so already, but it would be good to do at least one ILDiff of one of our shims and maybe compare it with our 2.x ones, to make sure that we actually match with those this time 😄

@ericstj
Copy link
Member Author

ericstj commented Mar 2, 2020

I did diff this when I made the arcade change. I'll rebuild and share a diff with the latest.

Looks like APICompat isn't happy with the new shims, I may need to investigate that.

@ericstj
Copy link
Member Author

ericstj commented Mar 2, 2020

Here's the diffs of mscorlib between 2.1 -> latest and 3.1 -> latest.
mscorlib-diff.zip

@ericstj ericstj force-pushed the shims-GenFacadesForceZeroVersionSeeds branch from 1403442 to 819853c Compare March 2, 2020 23:30
@ghost
Copy link

ghost commented Mar 3, 2020

Hello @ericstj!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit adc4f59 into dotnet:master Mar 3, 2020
@ericstj
Copy link
Member Author

ericstj commented Mar 3, 2020

@ericstj are we porting this to 3.1 as well ?

First I'd like to let this ship in a preview in 5.0, once we have confirmed it's ok we can port to servicing.

@jaredpar jaredpar mentioned this pull request Mar 3, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joperezr joperezr joperezr approved these changes

+1 more reviewer

@Anipik Anipik Anipik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ericstj ericstj

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericstj @Anipik @joperezr