Add spec: deserializing objects with parameterized ctors #33095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layomia
force-pushed
the
parameterized_ctors_spec
branch
from
3006d2b to
68f22e2
Compare
layomia
force-pushed
the
parameterized_ctors_spec
branch
from
68f22e2 to
fa1ed91
Compare
steveharter
reviewed
Mar 4, 2020
layomia
force-pushed
the
parameterized_ctors_spec
branch
from
a913b80 to
9063bf8
Compare
jozkee
added
the
documentation
terrajobst
reviewed
Mar 6, 2020
| with a message stating that objects without public parameterless constructors, including `interface`s and `abstract` | ||
| types, are not supported for deserialization. There is no way to deserialize an instance of an object using a parameterized constructor. | ||
|
|
||
| A common pattern is to make data objects immutable for various reasons. For example, given `Point`: |
Contributor
There was a problem hiding this comment.
Please note that this change alone won't support all immutable types. For example, our own immutable collections don't use constructors but factory methods.
terrajobst
reviewed
Mar 6, 2020
campersau
reviewed
Mar 12, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #29895.