Skip to content

Conversation

@hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Mar 5, 2020

According to https://en.wikipedia.org/wiki/Uname#Examples as pointed out by @danmosemsft matches most of the values we have used over time. Thanks @mdh1418 for the fix suggestion to use the -m flag.

@jkoritzinsky it's either this, or just return init-os-and-arch to the older fallback tree. Any reason to extend the tree as you did? Any impact on RIDs or other component builds? Specially for 1386?

Fixes #33164
Fixes #33211
Fixes #33210

@hoyosjs hoyosjs requested a review from jkoritzinsky March 5, 2020 09:18
@hoyosjs hoyosjs self-assigned this Mar 5, 2020
@jkoritzinsky
Copy link
Member

I extended the tree based on @am11’s feedback. I didn’t have any particular reason to extend it.

@am11
Copy link
Member

am11 commented Mar 5, 2020

@jkoritzinsky, this OSX build is before your PR was merged and has the same issue: https://dev.azure.com/dnceng/public/_build/results?buildId=514798&view=logs&j=8a742514-b8bd-5f7f-a706-89d0e8c57cc6&t=63254f6c-9351-50b1-ef65-7fd2e7d08b71&l=21. I think init-os-and-arch changes are irrelevant to this issue. Please CMIIW. :)

@jkoritzinsky
Copy link
Member

There's a slight difference from before my PR was merged and after. Before it was merged, i386 showed up as an "Unknown arch" so we would default to building for x64. After it was merged, we recognized i386, so we recognized it as an unsupported arch, but would still try to build for osx-x86 (which is expected, some of our partners build us for Linux x86 so we allowed it even though we don't support it).

@am11
Copy link
Member

am11 commented Mar 5, 2020

Thanks for the info @jkoritzinsky! I didn't realized this difference.
I also think -m is the right default. As a reference, please take a look at CMake's platform detection logic (which has quite a large array of supported platforms): https://github.com/Kitware/CMake/blob/e484b42/Modules/CMakeDetermineSystem.cmake#L46.

@hoyosjs hoyosjs force-pushed the juhoyosa/fix-mac-hostos branch from d28c4c6 to 2221bd8 Compare March 6, 2020 07:02
@hoyosjs
Copy link
Member Author

hoyosjs commented Mar 6, 2020

Failures are #33291 which are pre-existing. This doesn't touch any Windows bits.

@hoyosjs hoyosjs merged commit 820cc14 into master Mar 6, 2020
@hoyosjs hoyosjs deleted the juhoyosa/fix-mac-hostos branch March 9, 2020 19:35
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS ends up as marked as a cross build Version symbol missing from MacOS coreclr assets Building dotnet/runtime fails with exit code 253

6 participants