-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix uname usage and add binlogs #33223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I extended the tree based on @am11’s feedback. I didn’t have any particular reason to extend it. |
|
@jkoritzinsky, this OSX build is before your PR was merged and has the same issue: https://dev.azure.com/dnceng/public/_build/results?buildId=514798&view=logs&j=8a742514-b8bd-5f7f-a706-89d0e8c57cc6&t=63254f6c-9351-50b1-ef65-7fd2e7d08b71&l=21. I think |
|
There's a slight difference from before my PR was merged and after. Before it was merged, i386 showed up as an "Unknown arch" so we would default to building for x64. After it was merged, we recognized i386, so we recognized it as an unsupported arch, but would still try to build for osx-x86 (which is expected, some of our partners build us for Linux x86 so we allowed it even though we don't support it). |
|
Thanks for the info @jkoritzinsky! I didn't realized this difference. |
d28c4c6 to
2221bd8
Compare
|
Failures are #33291 which are pre-existing. This doesn't touch any Windows bits. |
According to https://en.wikipedia.org/wiki/Uname#Examples as pointed out by @danmosemsft matches most of the values we have used over time. Thanks @mdh1418 for the fix suggestion to use the -m flag.
@jkoritzinsky it's either this, or just return
init-os-and-archto the older fallback tree. Any reason to extend the tree as you did? Any impact on RIDs or other component builds? Specially for 1386?Fixes #33164
Fixes #33211
Fixes #33210