Skip to content

Add missing IAsyncDisposable interfaces to System.Data.Common #33265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericstj merged 1 commit into from
Mar 6, 2020
Merged

Add missing IAsyncDisposable interfaces to System.Data.Common #33265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/libraries/System.Data.Common/ref/System.Data.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1786,7 +1786,7 @@ protected DbColumn() { }
public int? NumericScale { get { throw null; } protected set { } }
public string UdtAssemblyQualifiedName { get { throw null; } protected set { } }
}
public abstract partial class DbCommand : System.ComponentModel.Component, System.Data.IDbCommand, System.IDisposable
public abstract partial class DbCommand : System.ComponentModel.Component, System.Data.IDbCommand, System.IDisposable, System.IAsyncDisposable
{
protected DbCommand() { }
[System.ComponentModel.DefaultValueAttribute("")]
Expand Down Expand Up @@ -1883,7 +1883,7 @@ protected void RowUpdatingHandler(System.Data.Common.RowUpdatingEventArgs rowUpd
protected abstract void SetRowUpdatingHandler(System.Data.Common.DbDataAdapter adapter);
public virtual string UnquoteIdentifier(string quotedIdentifier) { throw null; }
}
public abstract partial class DbConnection : System.ComponentModel.Component, System.Data.IDbConnection, System.IDisposable
public abstract partial class DbConnection : System.ComponentModel.Component, System.Data.IDbConnection, System.IDisposable, System.IAsyncDisposable
{
protected DbConnection() { }
[System.ComponentModel.DefaultValueAttribute("")]
Expand Down Expand Up @@ -2040,7 +2040,7 @@ protected virtual void TerminateBatching() { }
public int Update(System.Data.DataSet dataSet, string srcTable) { throw null; }
public int Update(System.Data.DataTable dataTable) { throw null; }
}
public abstract partial class DbDataReader : System.MarshalByRefObject, System.Collections.IEnumerable, System.Data.IDataReader, System.Data.IDataRecord, System.IDisposable
public abstract partial class DbDataReader : System.MarshalByRefObject, System.Collections.IEnumerable, System.Data.IDataReader, System.Data.IDataRecord, System.IDisposable, System.IAsyncDisposable
{
protected DbDataReader() { }
public abstract int Depth { get; }
Expand Down Expand Up @@ -2343,7 +2343,7 @@ public sealed partial class DbProviderSpecificTypePropertyAttribute : System.Att
public DbProviderSpecificTypePropertyAttribute(bool isProviderSpecificTypeProperty) { }
public bool IsProviderSpecificTypeProperty { get { throw null; } }
}
public abstract partial class DbTransaction : System.MarshalByRefObject, System.Data.IDbTransaction, System.IDisposable
public abstract partial class DbTransaction : System.MarshalByRefObject, System.Data.IDbTransaction, System.IDisposable, System.IAsyncDisposable
{
protected DbTransaction() { }
public System.Data.Common.DbConnection Connection { get { throw null; } }
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Data.Common/src/System/Data/Common/DbCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace System.Data.Common
{
public abstract class DbCommand : Component, IDbCommand
public abstract class DbCommand : Component, IDbCommand, IAsyncDisposable
{
protected DbCommand() : base()
{
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Data.Common/src/System/Data/Common/DbConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

namespace System.Data.Common
{
public abstract class DbConnection : Component, IDbConnection
public abstract class DbConnection : Component, IDbConnection, IAsyncDisposable
{
#pragma warning disable 649 // ignore unassigned field warning
internal bool _suppressStateChangeForReconnection;
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Data.Common/src/System/Data/Common/DbDataReader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace System.Data.Common
{
public abstract class DbDataReader : MarshalByRefObject, IDataReader, IEnumerable
public abstract class DbDataReader : MarshalByRefObject, IDataReader, IEnumerable, IAsyncDisposable
{
protected DbDataReader() : base() { }

Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Data.Common/src/System/Data/Common/DbTransaction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace System.Data.Common
{
public abstract class DbTransaction : MarshalByRefObject, IDbTransaction
public abstract class DbTransaction : MarshalByRefObject, IDbTransaction, IAsyncDisposable
{
protected DbTransaction() : base() { }

Expand Down
5 changes: 0 additions & 5 deletions src/libraries/shims/ApiCompatBaseline.netcoreapp.netstandardOnly.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ CannotRemoveAttribute : Attribute 'System.ComponentModel.BrowsableAttribute' exi
CannotRemoveAttribute : Attribute 'System.ComponentModel.DefaultValueAttribute' exists on 'System.ComponentModel.BackgroundWorker.WorkerReportsProgress' in the contract but not the implementation.
CannotRemoveAttribute : Attribute 'System.ComponentModel.DefaultValueAttribute' exists on 'System.ComponentModel.BackgroundWorker.WorkerSupportsCancellation' in the contract but not the implementation.
CannotRemoveAttribute : Attribute 'System.ComponentModel.BrowsableAttribute' exists on 'System.ComponentModel.RunWorkerCompletedEventArgs.UserState' in the contract but not the implementation.
CannotRemoveBaseTypeOrInterface : Type 'System.Data.DataTableReader' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbCommand' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbConnection' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbDataReader' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
CannotRemoveBaseTypeOrInterface : Type 'System.Data.Common.DbTransaction' does not implement interface 'System.IAsyncDisposable' in the implementation but it does in the contract.
CannotRemoveAttribute : Attribute 'System.ComponentModel.DefaultEventAttribute' exists on 'System.Diagnostics.Process' in the contract but not the implementation.
CannotRemoveAttribute : Attribute 'System.ComponentModel.DefaultPropertyAttribute' exists on 'System.Diagnostics.Process' in the contract but not the implementation.
CannotRemoveAttribute : Attribute 'System.ComponentModel.DesignerSerializationVisibilityAttribute' exists on 'System.Diagnostics.Process.BasePriority' in the contract but not the implementation.
Expand Down