-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Unconditionally upgrade installed Brew packages on OSX #33481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With Apt, if you have X 1.0 installed, 1.1 exists in the package manifest, and say "install X", X is upgraded to 1.1. With Brew, a fatal error is thrown. Blindly upgrading all previously installed packages is not ideal, and not a perfect mirror for the Apt behaviour, but it should mean that if X is previously installed it gets upgraded (causing a warning during install, when it's asked to be installed again with the same version), and if it's not already installed then it gets installed later. Closes: dotnet#33471
jashook
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this update our native toolsets unconditionally?
|
@jashook yup. But by calling As is, updating the package manifest to latest and asking "install the latest version of these 7 packages" will always cause failures when any one of those 7 is updated, as is the case today. Brew is not smart. |
|
Is there a way to limit the Either way we should proceed with some version of this as a stop gap measure. Builds are failing 100% right now (just verified). This will at least get us unblocked until we can find the appropriate longer term fix. |
|
Also seems to me if these machines already have a python3 installed (which seems to have changed) we just should not brew install python3 |
|
I was suggest a small check if python3 does not exists then brew install python |
|
@jaredpar |
|
We can put in a python specific conditional, as long as we're certain that there will never be an issue released for |
|
They would have to be present on the vm provided to us by azdo to have the conflict. Python3 seems understandable why they would add that, the rest may or may not be added. However, personally I find conditionally checking python3 and hoping the other packages are not added a safer solution. |
|
However, on further thought, we already always install the latest package anyways. So I think I am fine with either solution. |
|
Merging to unblock the ci. |
|
@directhex thank you for the quick fix |
With Apt, if you have X 1.0 installed, 1.1 exists in the package manifest, and say "install X", X is upgraded to 1.1. With Brew, a fatal error is thrown.
Blindly upgrading all previously installed packages is not ideal, and not a perfect mirror for the Apt behaviour, but it should mean that if X is previously installed it gets upgraded (causing a warning during install, when it's asked to be installed again with the same version), and if it's not already installed then it gets installed later.
Closes: #33471