Skip to content

.NET Core to .NET branding changes#33694

Merged
jkotas merged 2 commits intodotnet:masterfrom
jkotas:net5
Mar 28, 2020
Merged

.NET Core to .NET branding changes#33694
jkotas merged 2 commits intodotnet:masterfrom
jkotas:net5

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Mar 17, 2020

Contributes to #33680

@jkotas
Copy link
Member Author

jkotas commented Mar 17, 2020

This renames about 1/3 of all .NET Core references in the repo to just .NET. I have made sure that all user visible strings are renamed. The remaining instances are in docs or comments, and renaming them to just .NET would often be confusing, e.g. when they refer to specific version or difference against .NET Framework.

@jkotas jkotas requested a review from richlander March 17, 2020 22:44
@jkotas
Copy link
Member Author

jkotas commented Mar 17, 2020

Marking as breaking change. This can break code that checks for ".NET Core" in framework description, etc.

@jkotas jkotas added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Mar 17, 2020
@jkotas
Copy link
Member Author

jkotas commented Mar 18, 2020

Depends on dotnet/arcade#5086

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The email is for dotnetpackages@dotnetfoundation.org and the name is .NET Team. Should the name be .NET Foundation or something like that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced in dotnet/core-setup#2525 . @richlander Is there anything to fix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

".NET Team" looks good to me as the "maintainer".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tracing documentation is spread over multiple places. I believe it would be best to delete this doc, and centralize the documentation on the official docs site. I have opened dotnet/diagnostics#933 on it.

@jkotas
Copy link
Member Author

jkotas commented Mar 19, 2020

Blocked by dotnet/BenchmarkDotNet#1399

@jkotas jkotas added the blocked Issue/PR is blocked on something - see comments label Mar 19, 2020
@jkotas jkotas removed the blocked Issue/PR is blocked on something - see comments label Mar 27, 2020
@jkotas jkotas merged commit 4790673 into dotnet:master Mar 28, 2020
@jkotas jkotas deleted the net5 branch March 30, 2020 05:29
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Setup breaking-change Issue or PR that represents a breaking API or functional change over a previous release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants