[mono] Make some API functions public and private #33736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdageek
requested review from
CoffeeFlux,
SamMonoRT,
alexischr,
lewurm,
thaystg and
vargaz
as code owners
Member
|
heh, I was about to file an issue 🙂 |
Member
|
since #33633 is already merged could you please update |
lambdageek
force-pushed
the
add-xi-nonpublic-apis
branch
from
241e949 to
3df6e71
Compare
lambdageek
requested review from
EgorBo,
akoeplinger,
marek-safar and
steveisok
as code owners
lambdageek
force-pushed
the
add-xi-nonpublic-apis
branch
2 times, most recently
from
3e42c06 to
93a416a
Compare
Member
Author
|
Verified that the ios sample builds in Xcode. |
EgorBo
approved these changes
Mar 18, 2020
Contributor
|
So we didn't put them in public headers to avoid having to avoid users depending on them and thus having to support them forever. |
Member
|
@vargaz you could argue that with XI relying on them we're already on that path. Do you see any of these APIs as particularly problematic? |
lambdageek
changed the title
Member
Author
|
new plan:
|
It's already a MONO_API and it is used, for example, by Xamarin.iOS, but it wasn't in a public header. Mark it external only. There are no uses of it inside the runtiem
It was already used by Xamarin.iOS but wasn't in a public header and required compiling with --disable-visibility-hidden in order to dlsym the symbol. If --with-lazy-gc-thread-creation is used, embedders must call this function to create the finalizer therad. Otherwise the function does nothing and the runtime will create the finalizer thread automatically.
It was already marked as MONO_API, but it was not in a public header. It is used by embedders such as Xamarin.iOS
This reverts commit a0cc087.
lambdageek
force-pushed
the
add-xi-nonpublic-apis
branch
from
93a416a to
c037a3e
Compare
lambdageek
changed the title
Member
Author
|
Changed this PR to make @EgorBo could you check that the sample still compiles. |
Embedders don't need to call mono_trace_init before calling mono_trace_set_log_handler, mono_trace_set_print_handler or mono_trace_set_printerr_handler
We do not guarantee that this API will be stable
lambdageek
force-pushed
the
add-xi-nonpublic-apis
branch
from
c037a3e to
7dfc6ef
Compare
Member
|
@lambdageek just checked, compiles and works 👍 |
EgorBo
approved these changes
Mar 24, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #33633 and https://github.com/xamarin/xamarin-macios/blob/master/runtime/exports.t4
mono_install_load_aot_data_hookwas already aMONO_API, but it was not in a public header.It is added to
mono/jit/mono-private-unstable.hmono_gc_init_finalizer_threadwas used by Xamarin.iOS for a long time without being in any public header. It's one of the reasons we have to compile Mono for XI with--disable-visibility-hidden. Make the function a properMONO_APIunconditionally - but make it do nothing if the runtime is compiled without--with-lazy-thread-creation(the default). It is now a public Mono API function.mono_trace_initwas aMONO_APIfunction in a non-public header that was already used by embedders that need to set up logger hooks. It is now not necessary to call this before calling the logger functions to set up logger hooks such asmono_trace_set_log_handler