Enable Microsoft.Extensions.DependencyInjection #33816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryamariyan
commented
Mar 19, 2020
...ommon/tests/Extensions/TestingUtils/Microsoft.AspNetCore.Testing/test/AssemblyFixtureTest.cs
Outdated
Show resolved
Hide resolved
maryamariyan
commented
Mar 19, 2020
...ommon/tests/Extensions/TestingUtils/Microsoft.AspNetCore.Testing/test/ConditionalFactTest.cs
Outdated
Show resolved
Hide resolved
maryamariyan
commented
Mar 19, 2020
src/libraries/Microsoft.Extensions.DependencyInjection/tests/Common/src/AssemblyTestLog.cs
Outdated
Show resolved
Hide resolved
maryamariyan
commented
Mar 19, 2020
...ies/Microsoft.Extensions.DependencyInjection/tests/ServiceCollectionServiceExtensionsTest.cs
Outdated
Show resolved
Hide resolved
ericstj
reviewed
Mar 19, 2020
...t.Extensions.DependencyInjection/tests/Microsoft.Extensions.DependencyInjection.Tests.csproj
Outdated
Show resolved
Hide resolved
ericstj
reviewed
Mar 19, 2020
...t.Extensions.DependencyInjection/tests/Microsoft.Extensions.DependencyInjection.Tests.csproj
Outdated
Show resolved
Hide resolved
ericstj
reviewed
Mar 19, 2020
...t.Extensions.DependencyInjection/tests/Microsoft.Extensions.DependencyInjection.Tests.csproj
Outdated
Show resolved
Hide resolved
maryamariyan
force-pushed
the
fix-di-tests
branch
from
935dcc0 to
904c3db
Compare
maryamariyan
commented
Mar 19, 2020
...ies/Microsoft.Extensions.DependencyInjection/tests/ServiceCollectionServiceExtensionsTest.cs
Outdated
Show resolved
Hide resolved
maryamariyan
force-pushed
the
fix-di-tests
branch
from
904c3db to
716d136
Compare
safern
reviewed
Mar 19, 2020
...t.Extensions.DependencyInjection/tests/Microsoft.Extensions.DependencyInjection.Tests.csproj
Outdated
Show resolved
Hide resolved
safern
reviewed
Mar 19, 2020
Member
There was a problem hiding this comment.
It seems like this file should/could be converged with the AssertExtensions we have in our Private test utilities.
Contributor
Author
There was a problem hiding this comment.
- I'll mark this as todo when I'm cleaning up the unused files. (future PR)
Contributor
Author
Member
maryamariyan
requested review from
EgorBo,
akoeplinger,
marek-safar,
steveisok and
vargaz
as code owners
maryamariyan
commented
Mar 20, 2020
- Moves files under DI/tests/Common to Logging/tests/DI.Common as they are Logging tests - Simplifies and enables DI test csproj - TODO: Fix test on "ServiceCollectionServiceExtensionsTest.cs"
- Files under that directory already contained in: Microsoft.Extensions.DependencyInjection.Tests.csproj
needs all M.E.Configuration projects referenced
maryamariyan
force-pushed
the
fix-di-tests
branch
from
f4e27c4 to
b05e788
Compare
Contributor
Author
|
resolved conflict by rebase. |
ericstj
approved these changes
Mar 20, 2020
Member
|
Mono failure is #32377. I'm seeing this on all recent builds, so I don't think it's related to this change. |
Member
|
👏 |
maryamariyan
added
area-Extensions-DependencyInjection
and removed
area-Microsoft.Extensions
labels
11 tasks
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables DI and Options.