Close issues fixed by serializer refactoring #33819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layomia
added
area-System.Text.Json
test-enhancement
layomia
commented
Mar 20, 2020
src/libraries/System.Text.Json/tests/Serialization/ExtensionDataTests.cs
Show resolved
Hide resolved
Member
|
Can we close issue #1881 as well? I can provide you the respective tests. EDIT: Disregard my comment, we haven't decided the behavior for serializing types that are unsupported on deserialize. |
steveharter
reviewed
Mar 26, 2020
steveharter
reviewed
Mar 26, 2020
src/libraries/System.Text.Json/tests/Serialization/TestClasses.GenericCollections.cs
Outdated
Show resolved
Hide resolved
steveharter
reviewed
Mar 26, 2020
src/libraries/System.Text.Json/tests/Serialization/Value.ReadTests.GenericCollections.cs
Outdated
Show resolved
Hide resolved
steveharter
approved these changes
Mar 26, 2020
Contributor
steveharter
left a comment
steveharter
left a comment
There was a problem hiding this comment.
Other than a question and a couple nits, LGTM
|
In which version is this available? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issues fixed by #2259.
Fixes Support nullable structs in JsonSerializer #30843. Nullable structs were serialized with the "HasValue" and "Value" properties. This is fixed by the use of a converter for nullable structs and by unwrapping the value from the nullable before serializing it.
Fixes System.Text.Json - Collection was of a fixed size. Error on IEnumerable property #31089; fixes JsonSerializer throws InvalidCastException #31553. Deserializing collection properties that performed logic in their getters could throw exceptions. We no longer call the getter on deserializing, so this issue is fixed.