Add clrcompression static library#33922
Conversation
jkotas
left a comment
jkotas
left a comment
There was a problem hiding this comment.
We do this for all other libraries shim currently and this one is the only outlier. It is something we may need to revisit in future.
|
Related #3447 |
| ) | ||
|
|
||
| SET_TARGET_PROPERTIES(clrcompression-static PROPERTIES PREFIX "") | ||
| SET_TARGET_PROPERTIES(clrcompression-static PROPERTIES OUTPUT_NAME libclrcompression) |
There was a problem hiding this comment.
@NextTurn I have a couple of questions:
- Why do we add the lib prefix on Windows? This naming convention is Unix only.
- If we really want to do that for some reason, why don't we use the PREFIX property to do that instead of setting the PREFIX to an empty string and modifying the OUTPUT_NAME?
There was a problem hiding this comment.
Why do we add the lib prefix on Windows? This naming convention is Unix only.
There is already a clrcompression.lib on Windows serving as an import library. The lib prefix is taken from a similar library libnethost.lib as per discussion in dotnet/core-setup#8659.
If we really want to do that for some reason, why don't we use the PREFIX property to do that instead of setting the PREFIX to an empty string and modifying the OUTPUT_NAME?
Setting the PREFIX to lib seems to work as well... I'll take another look later.
There was a problem hiding this comment.
How about we set PREFIX to lib and then OUTPUT_NAME to clrcompression?
There was a problem hiding this comment.
Hmm, I have not realized before that we need to set the output name anyways, as it would be clrcompression-static by default. So I guess it is not worth the hassle to spend time changing it to set the PREFIX to lib. Please feel free to keep it as is.
ghost
locked as resolved and limited conversation to collaborators
4 participants
Contributes to dotnet/corert#5496
Uses the
libprefix per dotnet/core-setup#8659