Skip to content

Add service name to System.ServiceProcess.TimeoutException message #33927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
Mar 23, 2020
Merged

Add service name to System.ServiceProcess.TimeoutException message #33927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.ServiceProcess.ServiceController/src/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
<value>Cannot stop '{0}' service on computer '{1}'.</value>
</data>
<data name="Timeout" xml:space="preserve">
<value>Time out has expired and the operation has not been completed.</value>
<value>The operation requested for service '{0}' has not been completed within the specified time interval.</value>
</data>
<data name="PlatformNotSupported_ServiceController" xml:space="preserve">
<value>ServiceController enables manipulating and accessing Windows services and it is not applicable for other operating systems.</value>
Expand Down
2 changes: 1 addition & 1 deletion ...es/System.ServiceProcess.ServiceController/src/System/ServiceProcess/ServiceController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ public void WaitForStatus(ServiceControllerStatus desiredStatus, TimeSpan timeou
while (Status != desiredStatus)
{
if (DateTime.UtcNow - start > timeout)
throw new System.ServiceProcess.TimeoutException(SR.Timeout);
throw new System.ServiceProcess.TimeoutException(SR.Format(SR.Timeout, ServiceName));

_waitForStatusSignal.WaitOne(250);
Refresh();
Expand Down