JIT: block throw helper merges for first block of a try #34039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we may create a branch into the middle of a try. We could fix the transform, but if the first block of a try has a throw helper call, the rest of the try will subsequently be removed, so merging is not all that interesting. Addresses an issue that came up in dotnet#33924.
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
Member
Author
|
cc @dotnet/jit-contrib @Gnbrkm41 No diffs on x64 pmi. |
Member
Author
|
I think the test failures are infrastructure issues (404's from helix); going to retry. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we may create a branch into the middle of a try. We could fix the
transform, but if the first block of a try has a throw helper call, the rest
of the try will subsequently be removed, so merging is not all that
interesting.
Addresses an issue that came up in #33924.